Fix for issue #115 where Shopify/Laravel returns charge_id as string …

…instead of int
gnikyt · Oct 5, 2018 · 05a6931 · 05a6931
1 parent aed501b
commit 05a6931
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/ShopifyApp/Libraries/BillingPlan.php b/src/ShopifyApp/Libraries/BillingPlan.php
@@ -82,7 +82,7 @@ public function getCharge()
      * Activates a plan to the shop.
      *
      * Example usage:
-     * (new BillingPlan([shop], [plan]))->setChargeId(request('charge_id'))->activate();
+     * (new BillingPlan([shop], [plan]))->setChargeId((int) request('charge_id'))->activate();
      *
      * @return object
      */

diff --git a/src/ShopifyApp/Traits/BillingControllerTrait.php b/src/ShopifyApp/Traits/BillingControllerTrait.php
@@ -41,7 +41,7 @@ public function process($planId = null)
     {
         // Setup the shop and get the charge ID passed in
         $shop = ShopifyApp::shop();
-        $chargeId = request('charge_id');
+        $chargeId = (int) request('charge_id');
 
         // Setup the plan and get the charge
         $plan = $this->getPlan($planId);