Use stricter assertions. (#878)

gnikyt · Jul 9, 2021 · fc6c528 · fc6c528
1 parent 3fafd15
commit fc6c528
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 7 deletions.
diff --git a/tests/Macros/TokenRedirectTest.php b/tests/Macros/TokenRedirectTest.php
@@ -24,7 +24,7 @@ public function testTokenRedirect(): void
         $response = Redirector::tokenRedirect('home');
         $location = $response->headers->get('location');
 
-        $this->assertEquals(
+        $this->assertSame(
             'http://localhost/authenticate/token?shop=example.myshopify.com&target=http%3A%2F%2Flocalhost',
             $location
         );

diff --git a/tests/Macros/TokenRouteTest.php b/tests/Macros/TokenRouteTest.php
@@ -23,7 +23,7 @@ public function testTokenRoute(): void
         // Run the macro and get the link
         $result = UrlGenerator::tokenRoute('home');
 
-        $this->assertEquals(
+        $this->assertSame(
             'http://localhost/authenticate/token?shop=example.myshopify.com&target=http%3A%2F%2Flocalhost',
             $result
         );

diff --git a/tests/Objects/Transfers/ChargeTest.php b/tests/Objects/Transfers/ChargeTest.php
@@ -42,7 +42,7 @@ public function testSetThrowsAnError(): void
 
     public function testToArray(): void
     {
-        $this->assertEquals([
+        $this->assertSame([
             'shopId' => null,
             'planId' => null,
             'chargeReference' => null,

diff --git a/tests/Objects/Values/SessionTokenTest.php b/tests/Objects/Values/SessionTokenTest.php
@@ -21,10 +21,10 @@ public function testShouldProcessForValidToken(): void
         $this->assertTrue(Str::contains($this->tokenDefaults['dest'], $st->getShopDomain()->toNative()));
 
         $this->assertInstanceOf(SessionIdValue::class, $st->getSessionId());
-        $this->assertEquals($this->tokenDefaults['sid'], $st->getSessionId()->toNative());
+        $this->assertSame($this->tokenDefaults['sid'], $st->getSessionId()->toNative());
 
         $this->assertInstanceOf(Carbon::class, $st->getExpiration());
-        $this->assertEquals($this->tokenDefaults['exp'], $st->getExpiration()->unix());
+        $this->assertSame($this->tokenDefaults['exp'], $st->getExpiration()->unix());
     }
 
     public function testShouldThrowExceptionForMalformedToken(): void

diff --git a/tests/UtilTest.php b/tests/UtilTest.php
@@ -79,8 +79,8 @@ public function testGetShopifyConfig(): void
         $secret = Util::getShopifyConfig('api_secret');
         $grantMode = Util::getShopifyConfig('api_grant_mode');
 
-        $this->assertEquals('hello world', $secret);
-        $this->assertEquals('OFFLINE', $grantMode);
+        $this->assertSame('hello world', $secret);
+        $this->assertSame('OFFLINE', $grantMode);
     }
 
     public function testGraphQLWebhookTopic(): void