Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Adjustment to job classes for loose checking in constructor #140

Merged
merged 2 commits into from
Nov 19, 2018
Merged

Adjustment to job classes for loose checking in constructor #140

merged 2 commits into from
Nov 19, 2018

Conversation

awebartisan
Copy link
Contributor

While using ShopModelTrait, base Shop model or its child class is not passed in constructor of two jobs, WebhookInstaller and ScriptTagInstaller, so we can remove the type hinting from constructor to solve this issue.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 768fa3f on awebartisan:master into ce24ab5 on ohmybrew:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 768fa3f on awebartisan:master into ce24ab5 on ohmybrew:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 768fa3f on awebartisan:master into ce24ab5 on ohmybrew:master.

@coveralls
Copy link

coveralls commented Nov 15, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 768fa3f on awebartisan:master into ce24ab5 on ohmybrew:master.

@gnikyt gnikyt merged commit a0bf33f into gnikyt:master Nov 19, 2018
@gnikyt
Copy link
Owner

gnikyt commented Nov 19, 2018

thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants