This repository has been archived by the owner on Nov 30, 2022. It is now read-only.
bugfix/593 #732
Merged
bugfix/593 #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
gnikyt
commented
Mar 10, 2021
gnikyt
commented
- Ignore data sources on AuthShopify middleware when HMAC is not present
* AuthShopify middleware: moved implode of data sources to own function * AuthShopify middleware: implode of data sources now handles array and nested arrays
gnikyt
added a commit
that referenced
this pull request
Mar 10, 2021
* Fix to webhook stub to adjust 'domain' to 'shopDomain' * Fix high usage of memory during installation (#705) Co-authored-by: Clyde Dexter Santiago <clydesantiago@MacBook-Pro-M1.local> * Updated CONTRIBUTORS.txt * bugfix/593 (#732) * Fix for issue #742 * AuthShopify middleware: moved implode of data sources to own function * AuthShopify middleware: implode of data sources now handles array and nested arrays * SyleCI fix * Ignore data if no HMAC in AuthShopify middleware * Use named routes (#730) * Updated CONTRIBUTORS.txt * StyleCI fixes Co-authored-by: Clyde Dexter Santiago <31274021+clydesantiago@users.noreply.github.com> Co-authored-by: Clyde Dexter Santiago <clydesantiago@MacBook-Pro-M1.local> Co-authored-by: Scott Carpenter <scott@payforstay.com>
darrynten
reviewed
Mar 25, 2022
| $result = is_callable($value) ? $value() : $value; | ||
| if ($result !== null) { | ||
| // Found a shop | ||
| return ShopDomain::fromNative($result); |
There was a problem hiding this comment.
won't this just return whatever shop i inject into the http_referer variable?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.