Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model restructuring #290

Merged
merged 18 commits into from
Apr 18, 2023
Merged

Model restructuring #290

merged 18 commits into from
Apr 18, 2023

Conversation

klieret
Copy link
Member

@klieret klieret commented Apr 6, 2023

General changes:

  • Different output for ECs: Now return dictionary with W holding the weight

New flags for ECForGraphTCN:

  • use_node_embedding: concat node features for W prediction
  • use_intermediate_edge_embeddings:
  • Options to change residual connections

Changed flags:

  • There is only one e/n dimension for the INs
  • alpha instead of alpha_ec

Residual networks

  • Residual connections now independent independent of INs
  • Still have ResIn class that servers as convenience class

Remaining tasks

  • depth or L instead of L_ec?

@klieret klieret force-pushed the resinv2 branch 5 times, most recently from c2f43f6 to fe6348c Compare April 6, 2023 22:02
@klieret klieret changed the title Implement ResIN v2 Improved and more general residual networks Apr 7, 2023
@klieret
Copy link
Member Author

klieret commented Apr 9, 2023

don't rebase, because we already ran experiments with it, so hashes should be kept

@klieret klieret force-pushed the resinv2 branch 2 times, most recently from 2925952 to d0d252e Compare April 11, 2023 23:48
@klieret klieret changed the title Improved and more general residual networks More option for residual networks Apr 12, 2023
@klieret klieret force-pushed the resinv2 branch 3 times, most recently from 221a7a3 to cf988af Compare April 12, 2023 22:21
@klieret klieret changed the title More option for residual networks Model restructuring Apr 12, 2023
@klieret klieret force-pushed the resinv2 branch 5 times, most recently from 40e1a59 to 4eeb944 Compare April 14, 2023 21:49
@klieret klieret marked this pull request as ready for review April 18, 2023 21:15
@klieret klieret merged commit d765620 into main Apr 18, 2023
@klieret klieret deleted the resinv2 branch April 18, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant