Skip to content

Commit

Permalink
Pin oslo.policy<=3.4.0
Browse files Browse the repository at this point in the history
  • Loading branch information
@tobias-urdin
tobias-urdin committed Dec 4, 2020
1 parent ba5d73d commit a2d84f5
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion setup.cfg
View file
Expand Up @@ -27,7 +27,10 @@ install_requires =
numpy>=1.9.0
iso8601
oslo.config>=3.22.0
oslo.policy>=0.3.0
# TODO(tobias-urdin): oslo.policy >= 3.5.0 requires
# PyYAML>=5.1 which something we use blocks. Need
# to fix this to support Ubuntu Focal later.
oslo.policy>=0.3.0,<=3.4.0
oslo.middleware>=3.22.0
pytimeparse
pecan>=0.9
Expand Down

6 comments on commit a2d84f5

@mrunge
Copy link
Contributor

@mrunge mrunge commented on a2d84f5 Dec 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unfortunate. E.g. introducing secure RBAC OpenStack-wide requires oslo.policy >= 3.5.0

@tobias-urdin
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to track down what blocks from using PyYAML>=5.1 then we can unblock it.

@mrunge
Copy link
Contributor

@mrunge mrunge commented on a2d84f5 Dec 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the blocking part something inside of openstack, or is it something inside your env?

@tobias-urdin
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont know what dependency does not support pyyaml >= 5.1 yet

@tobias-urdin
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pip install pipdeptree
pipdeptree

would let us know what deps on it

@mrunge
Copy link
Contributor

@mrunge mrunge commented on a2d84f5 Dec 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I did pip install gnocchi and pip install pipdeptree.
I could not find anything requiring anything PyYAML < 5.1

(.venv) [stack@devstack gnocchi]$ pipdeptree | grep -i PyYaml
    - PyYAML [required: >=3.12, installed: 5.3.1]
      - PyYAML [required: >=3.12, installed: 5.3.1]
      - PyYAML [required: >=3.12, installed: 5.3.1]
    - PyYAML [required: >=5.1, installed: 5.3.1]

pip freeze:

(.venv) [stack@devstack gnocchi]$ pip freeze
beautifulsoup4==4.9.3
cachetools==4.1.1
certifi==2020.12.5
chardet==3.0.4
cotyledon==1.7.3
daiquiri==3.0.0
debtcollector==2.2.0
fasteners==0.15
futurist==2.3.0
gnocchi==4.4.0
idna==2.10
importlib-metadata==3.1.1
importlib-resources==3.3.0
iso8601==0.1.13
Jinja2==2.11.2
jsonpatch==1.28
jsonpointer==2.0
logutils==0.3.5
lz4==3.1.1
Mako==1.1.3
MarkupSafe==1.1.1
monotonic==1.5
msgpack==1.0.0
netaddr==0.8.0
netifaces==0.10.9
numpy==1.19.4
oslo.config==8.4.0
oslo.context==3.1.1
oslo.i18n==5.0.1
oslo.middleware==4.1.1
oslo.policy==3.6.0
oslo.serialization==4.0.1
oslo.utils==4.7.0
packaging==20.7
Paste==3.5.0
PasteDeploy==2.1.1
pbr==5.5.1
pecan==1.4.0
pipdeptree==1.0.0
pyparsing==2.4.7
python-json-logger==2.0.1
pytimeparse==1.1.8
pytz==2020.4
PyYAML==5.3.1
requests==2.25.0
rfc3986==1.4.0
setproctitle==1.2.1
six==1.15.0
soupsieve==2.0.1
statsd==3.3.0
stevedore==3.3.0
tenacity==6.2.0
tooz==2.8.0
ujson==4.0.1
urllib3==1.26.2
voluptuous==0.12.1
waitress==1.4.4
WebOb==1.8.6
WebTest==2.0.35
Werkzeug==1.0.1
wrapt==1.12.1
zipp==3.4.0

Please sign in to comment.