Fix Python 3.8, SQLAlchemy 1.4 and MySQL 8 #1147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gnocchixyz/devs please verify. |
|
Fixes #1146 |
tobias-urdin
force-pushed
the
py38-sqla1.4
branch
from
94d4052
to
dfabf2e
Compare
jd
reviewed
Jun 29, 2021
5 tasks
jd
previously requested changes
Jun 30, 2021
tobias-urdin
force-pushed
the
py38-sqla1.4
branch
from
26730c1
to
a68e191
Compare
jd
reviewed
Jun 30, 2021
gnocchi/indexer/alembic/versions/5c4f93e5bb4_mysql_float_to_timestamp.py
Show resolved
Hide resolved
tobias-urdin
force-pushed
the
py38-sqla1.4
branch
2 times, most recently
from
2f768a5
to
fffb2b0
Compare
Trying to alter drop a table that has a check constraint is not allowed.
* Fix list_metrics in amqp1d not properly validating list/set is not empty. * Dont set database or drivername on the new immutable SQLAlchemy URL object. * Validate values is not None before using.
We need to move to unittest.mock before enabling it.
tobias-urdin
force-pushed
the
py38-sqla1.4
branch
from
fffb2b0
to
62ee223
Compare
jd
previously approved these changes
Jun 30, 2021
tobias-urdin
changed the title
|
@Mergifyio backport stable/4.4 |
|
Command
|
tobias-urdin
added a commit
that referenced
this pull request
Jun 30, 2021
Fix Python 3.8, SQLAlchemy 1.4 and MySQL 8 (backport #1147)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes multiple issues.