Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3.9 #1234

Merged
merged 1 commit into from
Jun 14, 2022
Merged

Support Python 3.9 #1234

merged 1 commit into from
Jun 14, 2022

Conversation

kajinamit
Copy link
Contributor

This change adds Python 3.9 to supported python versions and adds
test coverage for it. CentOS Stream 9 now uses Python 3.9 by default
so the support is required to run Gnocchi in CentOS Stream 9.

This change also adds a few metadata items to setup.cfg to enforce
usage of Python >= 3.6.

jd
jd previously approved these changes May 28, 2022
@tobias-urdin
Copy link
Contributor

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Jun 2, 2022

rebase

✅ Branch has been successfully rebased

Copy link
Contributor

@tobias-urdin tobias-urdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Takashi! I've spent some time fixing CI again, let's see if this becomes green so we can merge it.

tox.ini Show resolved Hide resolved
@mergify mergify bot dismissed stale reviews from jd and tobias-urdin June 6, 2022 14:57

Pull request has been modified.

@tobias-urdin
Copy link
Contributor

Job will be fixed by merging #1246 or if we decide to drop cradox completely in 4.3 (4.3 is unmaintained so no CI there) #1248 provided as a courtesy.

@tobias-urdin
Copy link
Contributor

#1246 is merged, please resolve conflict and rebase.

@tobias-urdin
Copy link
Contributor

tobias-urdin commented Jun 13, 2022

@kajinamit please apply this diff, we need to skip Ceph jobs on Python 3.9 since Ubuntu 20.04 python3-rados bindings is only for Python 3.8 (default version in dist).

diff --git a/.github/workflows/gnocchi.yml b/.github/workflows/gnocchi.yml
index 58aee490..d318c0f8 100644
--- a/.github/workflows/gnocchi.yml
+++ b/.github/workflows/gnocchi.yml
@@ -88,6 +88,12 @@ jobs:
             python: py36
           - env: postgresql-ceph
             python: py36
+          - env: mysql-ceph-upgrade-from-4.4
+            python: py39
+          - env: mysql-ceph
+            python: py39
+          - env: postgresql-ceph
+            python: py39
     steps:
       - uses: actions/checkout@v2
       - run: sudo chown -R 1001:1001 $GITHUB_WORKSPACE

also remove those three jobs from mergify config for py39

@kajinamit
Copy link
Contributor Author

@tobias-urdin That makes sense. Thanks for the suggestion ! Applied the change.

This change adds Python 3.9 to supported python versions and adds
test coverage for it. CentOS Stream 9 now uses Python 3.9 by default
so the support is required to run Gnocchi in CentOS Stream 9.

This change also adds a few metadata items to setup.cfg to enforce
usage of Python >= 3.6.
Copy link
Contributor

@tobias-urdin tobias-urdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Sorry for all the fuzz with broken CI.

@kajinamit
Copy link
Contributor Author

Thanks! Sorry for all the fuzz with broken CI.

No problem, and thank you for your great help !

@tobias-urdin tobias-urdin merged commit 283663b into gnocchixyz:master Jun 14, 2022
@tobias-urdin
Copy link
Contributor

@Mergifyio backport stable/4.4

@mergify
Copy link
Contributor

mergify bot commented Jun 14, 2022

backport stable/4.4

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants