Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added max binary operator #1260

Merged
merged 6 commits into from
Jun 27, 2022
Merged

Added max binary operator #1260

merged 6 commits into from
Jun 27, 2022

Conversation

art-vasilyev
Copy link
Contributor

Add max operator to combine different metrics after applied operations.

Example:

(max (metric metric1 mean) (* (metric metric2 mean) 100)))

jd
jd previously requested changes Jun 22, 2022
Copy link
Member

@jd jd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

release note maybe?

@mergify mergify bot dismissed jd’s stale review June 22, 2022 14:47

Pull request has been modified.

Copy link
Contributor

@tobias-urdin tobias-urdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please add a simple test for the new operator as well, see review you need to use double backticks in release note.

---
features:
- |
Added `max` operator to combine different metrics after applied operations.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to use double backticks for the formatting here.

@mergify mergify bot dismissed tobias-urdin’s stale review June 27, 2022 08:05

Pull request has been modified.

tobias-urdin
tobias-urdin previously approved these changes Jun 27, 2022
@mergify mergify bot dismissed tobias-urdin’s stale review June 27, 2022 10:44

Pull request has been modified.

@mergify mergify bot merged commit 5b5bb1c into gnocchixyz:master Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants