Adjust metric not found exception #1286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelweingartner
force-pushed
the
adjust_metric_not_found_exception
branch
5 times, most recently
from
3b06904
to
f3a4880
Compare
Following the discussion on [1], Gnocchi was not properly handling the metric not found exceptions, which in turn causes a problem with Gnocchi client. The exceptions were being rendered as a JSON, and not a string inside the description field. This PR fixes that. [1] gnocchixyz/python-gnocchiclient#133 (comment)
rafaelweingartner
force-pushed
the
adjust_metric_not_found_exception
branch
from
f3a4880
to
02fd55c
Compare
|
Thanks! This makes sense. |
tobias-urdin
approved these changes
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the discussion on [1], Gnocchi was not properly handling the metric not found exceptions, which in turn causes a problem with Gnocchi client.
The exceptions were being rendered as a JSON, and not a string inside the description field. This PR fixes that.
The problem seems to have been caused by: 455c1b9
P.S. There are some other situations that the response is a JSON inside the description attribute. I would prefer as is and fix the issue in the Client. However, I see that this would break the backward compatibility.
[1] gnocchixyz/python-gnocchiclient#133 (comment)