Accept float values for socket_timeout #1299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kajinamit
force-pushed
the
socket_timeout-float
branch
from
9af51c3
to
414f01b
Compare
kajinamit
changed the title
|
@Mergifyio rebase |
❌ Unable to rebase: user
|
|
@Mergifyio rebase |
The socket_timeout argument of redis client supports not only integers but also floats. This allows users to pass float values[1]. [1] https://github.com/redis/redis-py/blob/1b2f408259/redis/connection.py#L1206
✅ Branch has been successfully rebased |
tobias-urdin
force-pushed
the
socket_timeout-float
branch
from
414f01b
to
456f57b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The socket_timeout argument of redis client supports not only integers
but also floats. This allows users to pass float values[1].
[1] https://github.com/redis/redis-py/blob/1b2f408259/redis/connection.py#L1206