Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gnocchi build with latest setuptools #1305

Closed
wants to merge 1 commit into from

Conversation

keuko
Copy link

@keuko keuko commented Jun 20, 2023

Setuptools removed deprecated APIs in easy_install: get_script_args, get_script_header and get_writer. The direct usage of easy_install has been deprecated since v58.3.0, and the warnings regarding these APIs predate that version.

This patch fix this issue by replacing direct easy_install call easy_install.get_script_header() with
easy_install.ScriptWriter.get_header().

Build error:

AttributeError: module 'setuptools.command.easy_install' has no attribute 'get_script_header'

Fixes #1304

@artificial-intelligence

notice though that easy_install itself is deprecated as well.

it is suggested to use pip instead:

https://setuptools.pypa.io/en/stable/deprecated/easy_install.html

Copy link

@artificial-intelligence artificial-intelligence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this fixes the immediate error, but doesn't fix the deprecated usage of easy_install itself.

@keuko keuko force-pushed the master branch 2 times, most recently from e0a80db to a1dcb2b Compare June 20, 2023 13:07
Setuptools removed deprecated APIs in easy_install:
get_script_args, get_script_header and get_writer.
The direct usage of easy_install has been deprecated
since v58.3.0, and the warnings regarding these APIs
predate that version.

This patch fix this issue by replacing direct easy_install
call easy_install.get_script_header() with
easy_install.ScriptWriter.get_header().

Build error:

AttributeError: module 'setuptools.command.easy_install'
has no attribute 'get_script_header'

Fixes gnocchixyz#1304
@tobias-urdin
Copy link
Contributor

immediate issue will be fixed by #1314 – still using deprecated behaviour will perhaps use the opened pbr patch for that if details can be sorted out

@tobias-urdin
Copy link
Contributor

Closing as immediate issue is fixed in stable branches and master now completely removed that code #1327

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

gnocchi failed to build with latest setuptools
3 participants