You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Propose refactoring p/ownable from a struct with a specific implementation to a more minimal interface, allowing for custom ownership logic while retaining the current struct as the default implementation.
Details
Minimal Interface: Define a minimal interface, possibly just Owner() std.Address. Enabling read-only usage of Ownable everywhere with the possibility of custom ownership logic.
Default Implementation: Retain the current struct as the default implementation.
Extended Interface: Keep the current helpers (e.g., Transfer) in another interface, like Transferrable which embeds Ownable.
I think I understand this issue. If permitted, can I create a pull request to resolve it?
moul
changed the title
minimal p/ownable Interface with multiple implementations
minimal p/ownable Interface with multiple implementations
May 25, 2024
#2198
hey @moul@leohhhn I have implemented the PR for this issue. Can you take a look and provide any feedback? Do we need to add a custom implementation ?
Propose refactoring
p/ownable
from a struct with a specific implementation to a more minimal interface, allowing for custom ownership logic while retaining the current struct as the default implementation.Details
Owner() std.Address
. Enabling read-only usage ofOwnable
everywhere with the possibility of custom ownership logic.Transfer
) in another interface, likeTransferrable
which embedsOwnable
.cc @leohhhn
The text was updated successfully, but these errors were encountered: