Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No linters are enabled #255

Closed
alikhil opened this issue Jun 20, 2022 · 3 comments
Closed

No linters are enabled #255

alikhil opened this issue Jun 20, 2022 · 3 comments
Milestone
💡Someday/Maybe

Comments

@alikhil
Copy link
Contributor

alikhil commented Jun 20, 2022

Hi!

I would suggest to enable some linters on this repo. For example by using golangci-lint.

It will help to catch some bugs early and keep code quality at good level.

This is a short list of potential bugs found by staticcheck linter:
image
@alikhil
Copy link
Contributor Author

alikhil commented Jun 24, 2022

@moul @jaekwon what do you think about it?
If you think that it would be useful then I can spend some time to configure it

@moul
Copy link
Member

moul commented Jun 24, 2022

Yep, I like the idea, and I can monitor over time to adjust the config if needed

@moul moul added this to the 💡Someday/Maybe milestone Oct 20, 2022
@thehowl
Copy link
Member

thehowl commented Feb 20, 2023

Done with #472

@thehowl thehowl closed this as completed Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
🚀 The Launch
Archived in project
Milestone
💡Someday/Maybe
Development

No branches or pull requests
3 participants
@moul @thehowl @alikhil