setup.py: open catalogs using UTF-8 in python 3 #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise they might be opened as ascii, leading to a UnicodeDecodeError.
RyuzakiKK
approved these changes
Apr 23, 2018
|
Amazing. Thanks! I wonder: Can we use the argument unconditionally? That would make the patch even simpler. |
|
|
|
Ah, right. I was a bit confused. I was looking as codecs.open. That can be used in Python 2 and 3. |
|
Thanks for the patch! Awesome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise they might be opened as ascii, leading to a UnicodeDecodeError.