wormholeoffer: prevent unhandled LonelyError #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the recent wormhole versions (probably from the 0.11.0) the close() behaviour slightly changed. In keysign output we got this message when we cancelled a pending sending operation: ``` Unhandled error in Deferred: Traceback (most recent call last): Failure: wormhole.errors.LonelyError: ``` To solve this I added an error callback to the close function. Because we still catch every possible errors in the start() function, here I just redirect the error output to `log.debug`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the recent wormhole versions (probably from the 0.11.0) the close()
behaviour slightly changed.
In keysign output we got this message when we cancelled a pending
sending operation:
To solve this I added an error callback to the close function. Because
we still catch every possible errors in the start() function, here I
just redirect the error output to
log.debug.