Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Croatian translation #607

Merged
merged 3 commits into from Jan 9, 2022

Conversation

milotype
Copy link
Contributor

@milotype milotype commented Jan 7, 2022

Add Croatian translation

Add "hr" for Croatian translation
Minor corrections in Croatian translation
@kamilprusko
Copy link
Collaborator

Thanks :)

Looks good. Only, I'm not sure about plural forms. Other projects like gedit / glib use this setting:

"Plural-Forms: nplurals=3; plural=n%10==1 && n%100!=11 ? 0 : n%10>=2 && n"
"%10<=4 && (n%100<10 || n%100>=20) ? 1 : 2;\n"

Which setting is correct?

@milotype
Copy link
Contributor Author

milotype commented Jan 9, 2022

I'm not a programmer, so I can't explain it.
When I translate with the Poedit app, it uses

"Plural-Forms: nplurals=3; plural=(n%10==1 && n%100!=11 ? 0 : n%10>=2 && n"
"%10<=4 && (n%100<12 || n%100>14) ? 1 : 2);\n"

When I translate with Weblate it, it uses

"Plural-Forms: nplurals=3; plural=n%10==1 && n%100!=11 ? 0 : n%10>=2 && n"
"%10<=4 && (n%100<10 || n%100>=20) ? 1 : 2;\n"

According to the Poedit programmer (vslavik) there is no real difference. Please see his comment at the bottom of the issue at GitHub vslavik/poedit#596 (comment).

Also, I've never noticed any difference in translations using either one of the plural-forms settings.
Hope this helps …

@kamilprusko kamilprusko merged commit 1999185 into gnome-pomodoro:master Jan 9, 2022
@kamilprusko
Copy link
Collaborator

Indeed they are equivalent.

Thanks again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants