Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UTF-8 character breaks terminator config file #577

Closed
brean opened this issue Feb 1, 2022 · 3 comments
Closed

UTF-8 character breaks terminator config file #577

brean opened this issue Feb 1, 2022 · 3 comments

Comments

@brean
Copy link

brean commented Feb 1, 2022

Describe the bug
After adding an UTF-8 character to the config file (e.g. in a custom command) terminator is not able to save the config file anymore and instead empties it.

terminator.txt

To Reproduce

  1. load the attached terminator.txt-file, e.g. terminator -g terminator.txt.
  2. Right click -> Preferences
  3. change anything (e.g. save the layout)
  4. take a look at the terminator.txt-file. It is empty now.

Expected behavior
The terminator.txt file should not be empty, instead the configuration should be saved correctly

Screenshots
(not applicable)

Desktop (please complete the following information):

  • Distros: Ubuntu
  • Versions: 20.04
  • Display Technology: X11
  • Terminator Version: 1.91

Additional context
I am getting this error message:
ConfigBase::save: Unable to save config: 'ascii' codec can't encode character '\u2757' in position 165: ordinal not in range(128)

(I have not tried any other UTF-8 characters beside the heavy exclamation mark)

@Vulcalien
Copy link
Member

Hi! I can confirm that in version 1.91 the problem occurs in Ubuntu 20.04 (haven't tested anywhere else).
But in the latest version (git repository) it seems to be fixed (tested Ubuntu 20.04 and Debian).

Unfortunately, some distros ship old versions (1.91 is 5 years old).
If the error causes you troubles, I suggest you clone the repository and use the newest version instead.

@brean
Copy link
Author

brean commented Feb 5, 2022

Thanks for the update. My Workaround for now is to not use UTF-8 when calling a program. Because it works on the git master I close this issue now.

@brean brean closed this as completed Feb 5, 2022
@mattrose
Copy link
Member

mattrose commented Feb 6, 2022

There's also a PPA I maintain that you can use to get more recent versions. Instructions are in INSTALL.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants