-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logger plugin crashes with "TypeError: 'NoneType' object is not subscriptable" #776
Comments
Can you tell me what version of vte you're running? you should be able to just run I have a feeling that it's related to this:
Unfortunately I can't make any sense of this sentence. |
Hi @mattrose , #Arch:
$ pacman -Q | grep vte
vte-common 0.72.2-1
vte3 0.72.2-1
#Ubuntu23.04:
sudo dpkg -l | grep vte
ii gir1.2-vte-2.91:amd64 0.72.0-1
ii libvte-2.91-0:amd64 0.72.0-1
ii libvte-2.91-common 0.72.0-1 |
It definitely works with vte 0.70. I can't figure out what I need to change to make my call compatible with the newer version, so I've opened https://gitlab.gnome.org/GNOME/vte/-/issues/2633 |
Vte.Terminal().get_text_range erroneously returns None as of vte 0.72 basically as a bug in the introspection attributes, see the vte bug details. There is a new, undocumented call get_text_range_format that does work in 0.72, so I'll plug that method call in to the plugin for now. Patch incoming |
I still need to test that patch on an older vte, but it should work there as well as on 0.72 and newer. |
Starting the "terminator" without the config file gives the same results.
Fill out as many of these fields as you can
Describe the bug
The logger plugin does not work with the new gnome-terminal (tested it on ubuntu 23.04 and on the rolling release of Arch), the plugin crashes with "TypeError: 'NoneType'"
To Reproduce
Start the logger, select the destination file, produce a terminal output (example: ps -Af), and stop the logger. The logger will fail to stop and no content is written to the output file.
Expected behavior
Termina output is written to output file
Screenshots
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: