Broadcast issues additional key to terminals

[Isgleas]

When grouping terminals and broadcasting on them, the keys typed on the focused one are keyed twice on the other terminals.

Lets say, if I type ls on the main terminal, I get llss on the others on the group. The same happens when setting broadcast to all,

Terminator v 1.91 on Opensuse Leap 15.1

[mattrose]

I believe this has been fixed in master. Can you try:

git clone https://github.com/gnome-terminator/terminator
cd terminator
./terminator -u

to try it out?

[Isgleas]

I see the same behavior

[lazyfrosch]

confirmed in my setup

[mattrose]

weird, I'm not seeing that either on fedora or my mac, and my mac terminator install is as quirky as hell :)

[mattrose]

[Isgleas]

I have found this issue happens if I'm on KDE Xorg, it does not show neither on KDE Wayland, Gnome Wayland nor Gnome Xorg. I have tried modifying some of the keyboard related env variables but none of them seem to affect

[Isgleas]

Closed it by mistake

[mattrose]

FOUND IT! It is, as I thought an issue with ibus grabbing keypress events and then sending them back.

It's ibus/ibus#2036

There are a bunch of issues around it, but I'm gonna take the same big hammer approach to the problem as Stephen took.

If you hit this bug and want to work around it, simply ensure the following environment variable is set before starting terminator:
IBUS_NO_SNOOPER_APPS=python3

[mattrose]

Well, this was an adventure. It turns out that it wasn't the environment variable that changed, but actually the internals of the python psutil module, which meant that we weren't actually detecting whether or not ibus was running, and consequently never setting the proper ibus environment variable.

Can anyone who has encountered this bug please check out the PR and test it?

[Isgleas]

Setting the environment variable seems to fix the broadcast issue, but some shortcuts, not all, start working funny, like triggering an emoji list menu

[Isgleas]

PR114 seems to work, great!

[mattrose]

Great, I'll pull this in soon. Thanks for testing it out so quickly.

[ozzdemir]

It still happens to me with commit 6c56f32
Tried deleting environment variable by adding del os.environ['GTK_IM_MODULE'] to terminator before main called. It works, but then I cant launch a layout from Terminator Layout Launcher.
Using Ubuntu 18.04, and installed from source with the mentioned commit.

[mattrose]

I'm going to re-open this to check this out.

[ozzdemir]

When I tried to start layout from terminal, observed that it was giving keyError since GTK_IM_MODULE env var is already deleted (probably), when I handled it in a try except block, now I can start from layout. Final form of the addition (Just before if __name__ == '__main__':) I made is as follows:

try:
    del os.environ['GTK_IM_MODULE']
except Exception as e:
    print(e)

I did not open a merge request since I am not sure if this is the best way to handle it, but if anyone wants a quick solution can use it.

[mattrose]

I reverted #36, can you retest this and close it if it's fixed again?

[ozzdemir]

Checked issue78 branch, and there was no such problem, but master branch still has it.

[mattrose]

Did you update master from upstream?

[ozzdemir]

Yes, I did at the time and tried again just now. Still persists.
terminator --version reports terminator 2.1.0. If there is a call that returns the commit hash or so, I can also share it.

[ozzdemir]

It seems the bug introduced by 736e88a. I did find it by sectioning commits and testing for the problem.

[mattrose]

Hmm, can you see if the ibus fix referenced in that commit is in your version of ibus?

[ozzdemir]

How can I check it? Seems my IBus version is 1.5.17.

[mattrose]

That should have the fix in it, I'll see if I can reproduce this in an ubuntu 18.04 vm soon

[Joshua-Snapp]

I also have this problem when broadcasting to multiple panes. The current workaround that seems to work is to set DBUS_SESSION_BUS_ADDRESS='' and start terminator with the -u option described in the DBus section of the Terminator documentation.

I added the following alias to my ~/.bashrc to make this workaround more convenient to run.

alias terminator="DBUS_SESSION_BUS_ADDRESS='' terminator -u"

I'm running the following:

• Fedora 32
• ibus.x86_64 1.5.22-7.fc32
• terminator.noarch 2.1.0-1.fc32
• gtk3.x86_64 3.24.23-1.fc32

Enabled Terminator Plugins:

• LaunchpadBugURLHandler
• LaunchpadCodeURLHandler
• APTURLHandler
• TerminatorThemes
• TerminatorSearch

[xbello]

I've been able to make it work creating the executable file ~/bin/terminator (assuming your ~/bin has preference) as:

export DBUS_SESSION_BUS_ADDRESS=$(dbus-launch)
/usr/bin/terminator

I did this because the terminator.desktop launcher doesn't seem to use the alias from the .bashrc

[mattrose]

I think this workaround is best if anyone is still hitting this issue. Anytime I try and fix this in code it breaks more critical functionality.

[kimba74]

Hi @mattrose

Looks like this bug is back starting with terminator version v2.1.0

I installed terminator from your PPA and got an update a few hours ago from 2.0.1-1-0ubuntu3 to 2.1.1-2 since then I get the double input on split terminal again. The insert_number feature also crashes with error:

Traceback (most recent call last):
  File "/home/steffen/Development/Languages/Python/terminator/terminatorlib/terminator.py", line 592, in do_enumerate
    term.feed(numstr % (idx + 1))
  File "/home/steffen/Development/Languages/Python/terminator/terminatorlib/terminal.py", line 1584, in feed
    self.vte.feed_child(text)
TypeError: Item 0: Must be number, not str

To verify that it was working earlier I cloned your repo and tested the tags backwards:

Tag	Result
v2.1.1	Broken
v2.1.0	Broken
v2.0.1	Works

So I guess somewhere the changes you made to fix this bug in git lost after version v2.0.1

I'm running Ubuntu 20.04.

Let me know if I can provide additional information to help narrow down the issue.

Cheers,

Kimba

[yuki]

Same issue on Terminator 2.1.0-2 on Debian bookworm (actually "testing").
The workaround

export DBUS_SESSION_BUS_ADDRESS=$(dbus-launch)
/usr/bin/terminator

is working

[yurenchen000]

ubuntu20.04, fcitx google-pinyin.

the situation I encountered:

env other

// this no effecit

QT4_IM_MODULE= QT_IM_MODULE= DBUS_SESSION_BUS_ADDRESS= /usr/bin/terminator -u

env GTK_IM_MODULE

// this fixed, but will lose fcitx input

GTK_IM_MODULE=  /usr/bin/terminator -u

// this fixed, but also lose fcitx input

--- a/usr/bin/terminator
+++ b/usr/bin/terminator
@@ -23,6 +23,12 @@ import sys
 import os
 import psutil
 import pwd
+
+try:
+    del os.environ['GTK_IM_MODULE']
+except Exception as e:
+    print(e)
+
 try:
     ORIGCWD = os.getcwd()
 except OSError:

so, the current workaround principle is disable input method ?
may be this is a temporary workaround ?

[JKomoroski]

For those using terminator 2.1.1 and are launching terminator from a .desktop shortcut (i.e Fedora). I was able to work around this issue edit the Exec argument to include an empty Dbus address.

Copy the system terminator desktop file to my local application shortcut directory. For example on my system:

cp /usr/share/applications/terminator.desktop ~/.local/share/applications 

Open the copied result file in the local applications folder and edit the Exec=terminator to:

Exec=env DBUS_SESSION_BUS_ADDRESS= terminator -u

[Arondight]

Damn you can't delete the GTK_IM_MODULE environment variable, tons of users need to use it! THIS CODE SUCKS!

[mattrose]

agreed, that's why I pulled it in the latest release.

[bmullan]

On Ubuntu 22.04.3 LTS

My Terminator got updated sometime recently to a newer version that exhibited the duplicate character issue when
Broadcasting between multiple Terminator "window" sessions.

I finally fixed it on my system by editing:

$ sudo nano /usr/share/applications/terminator.desktop

Change the line "Exec=terminator" to:

Exec=env DBUS_SESSION_BUS_ADDRESS= terminator -u

Testing:

Start Terminator, split the window so you have 2 Terminator sessions.
In one of those select Broadcast All

It now works again on my Ubuntu system w/no character duplication!

[awsms]

still having this issue on 2.1.3

[xbello]

On Ubuntu 22.04.3 LTS

My Terminator got updated sometime recently to a newer version that exhibited the duplicate character issue when Broadcasting between multiple Terminator "window" sessions.

I finally fixed it on my system by editing:

$ sudo nano /usr/share/applications/terminator.desktop

This kind of changes might be overwritten in the next upgrade. It could be in a couple of months or in a couple of years. And then you won't remember how did you fix it.

You should edit instead your user terminator.desktop that usually is at $HOME.local/share/applications/. If it doesn't exist, create one by copying the file from the system.