Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix: 'Clear selection on copy' is always unchecked #443

Merged
merged 1 commit into from
Jun 3, 2021

Conversation

Vulcalien
Copy link
Member

The checkbox for "Clear selection on copy" was always unchecked, because the widget active status was not set.
And the id of the checkbox in preferences.glade was not set.

To Reproduce

Try to check "Clear selection on copy" and then close the preferences menu. When opened again, it's unchecked.

@mattrose mattrose merged commit f4a3c4e into gnome-terminator:master Jun 3, 2021
@mattrose
Copy link
Member

mattrose commented Jun 3, 2021

Thanks again for all your help. I'm really busy with other life aspects right now and this really does help, both the project and me mentally. Nothing makes me happier than seeing an unbidden PR that fixes a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants