GUI: set all CheckButtons off to avoid blinking + remove grid empty rows/columns #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small change to the preferences.glade file.
After the last PR (#481) I've noticed some of the checkboxes "blink".
Basically, in the glade file, they are "on", but when terminator reads the config file, they are set off. So there is this very small time span where they are on, and suddenly turn off, causing some sort of blinking.
I think the reasons because this did not happen before, is that the GUI was bigger and there was more stuff to load, so there was enought time to read and set all the settings.
So I set all checkboxes to false by default, so that they turn on only when Terminator reads the config. I also removed some empty rows/columns from that file.