Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cursor: make it possible to change foreground color (#467) #486

Merged
merged 6 commits into from
Aug 16, 2021

Conversation

Vulcalien
Copy link
Member

There were some changes to the GUI and to the config file.
Let's talk about the last one first.

Config

Currently, there are only two settings for the cursor colors: cursor_color and cursor_color_fg. Their names can easily confuse, because cursor_color is the background color, while cursor_color_fg is a boolean (False = use a custom background; True = use the foreground as the background).
I removed them both, and replaced them with three new settings: cursor_fg_color, cursor_bg_color and cursor_color_default. The first two are color strings, foreground and background. The last is a boolean (False = custom colors, True = default colors).

Python code

Most of the changes are made to make the new GUI work.
I removed the old signal functions and the old logic that initializes the cursor colors in the preferences menu, replacing everything with the new code.

GUI

I changed the GUI related to the cursor, in the Profiles > Global tab.

I also fixed some inconsistencies that I noticed in the whole menu:

  • "Text color" and "Font color" are now "Foreground"
  • On the Profiles > Titlebar the Font selector was missing the "indentation"
  • "Background color" in Profiles > Colors is now just "Background"

@mattrose
Copy link
Member

Working on another feature right now, but I'll take a look at this by monday hopefully

@mattrose
Copy link
Member

Wow, this was a lot more work than I thought it was. Great job, and thanks again.

@mattrose mattrose merged commit 6904998 into gnome-terminator:master Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants