Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix: hide_window keybinding ignores Shift key #510

Merged
merged 1 commit into from Sep 11, 2021

Conversation

Vulcalien
Copy link
Member

@Vulcalien Vulcalien commented Sep 11, 2021

Fixes #509

The shift key gets ignored by the global Keybinder. That's not a bug in the library, it's a misconfiguration.
By default, keybinder uses "cooked accelerators".

I quote from the issue comments.

The best documentation I found is the comments in the code. They are pretty good.
From this:

"Cooked" accelerators use symbols produced by using modifiers such as shift or altgr, for example if "!" is produced by "Shift+1".

There is this C function

keybinder_set_use_cooked_accelerators

So yeah, we just had to disable them using this:

Keybinder.set_use_cooked_accelerators(False)

There is another issue about hide_window not working (#427). I doubt it's related to this, I think that one is about Wayland.

@mattrose mattrose merged commit 28a2b03 into gnome-terminator:master Sep 11, 2021
@mattrose
Copy link
Member

thanks! Merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hide_window mapped with Shift+Control+Alt+$an_alphabet catches Control+Alt+$an_alphabet instead
2 participants