Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoom on notebook even if there is only one terminal in the tab + keep tab position and label in notebook rotation #589

Merged
merged 4 commits into from Nov 19, 2022

Conversation

Vulcalien
Copy link
Member

The problem

When there are multiple tabs, the notebook top bar is visible.
Now, it is possible to split the terminal and then zoom/maximize, so that the top bar is hidden.
But when there is only one terminal in the notebook tab, it's not possible to do it.

Solution

I added the signals for the notebook, so that it does zoom/maximize now.

Current bug

When unzooming a tab with a single terminal in it, the tab is moved to the end of the notebook.
I currently have no idea why it does that, but since it can be annoying I think it's best to fix it before merging.

Second commit

The function I deleted in the second commit (container.py) seems to be unused. Nowhere it's called and other functions do the same thing.

@Vulcalien Vulcalien marked this pull request as ready for review May 20, 2022 11:13
@Vulcalien
Copy link
Member Author

Ok I've fixed the bug!

Since I don't think I explained what this PR does nicely, here is what I mean:
zoom-notebook-0

zoom-notebook-1

To zoom, both the key mapping and the right-click GUI menu seem to work fine.

@mattrose
Copy link
Member

Thank you so much. Looks good at first glance, I'm gonna pull it down and run it myself to make sure, but at this point you probably know the code as well as anyone else does 😄

@Vulcalien
Copy link
Member Author

I've been using this branch since I made it, and so far I see no bugs in it.
I looked at the code and can confirm that toggle_zoom is never used anywhere.

It's not really that useful of a change, more like a "why not" thing.

@Vulcalien Vulcalien mentioned this pull request Aug 24, 2022
1 task
@Vulcalien Vulcalien changed the title Zoom on notebook even if there is only one terminal in the tab Zoom on notebook even if there is only one terminal in the tab + keep tab position and label in notebook rotation Aug 27, 2022
@Vulcalien Vulcalien added the enhancement New feature or request label Oct 19, 2022
@mattrose
Copy link
Member

Looks good, sorry about the wait.

@mattrose mattrose merged commit a83ee32 into gnome-terminator:master Nov 19, 2022
@Vulcalien Vulcalien deleted the zoom-on-notebook branch March 10, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants