[bug 613] - Shortcut for autosplit h/v depending on active terminal … #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ize gnome-terminator#613 -added auto split feature -new signal split-auto was added -currently this uses widget dimensions for the split as rows, cols were having different space and was not consistent, this can be changed if needed -short cut was also added -icon for the menu item needs to be added
|
checking why the key binding conflict. 'edit_tab_title', 'a') |
-had to comment out test for ctrl shift a (need to cross check)
|
I had missed split_auto in prefs editor. Note: But the check in tests/test_prefseditor_keybindings.py had to be disabled, kindly cross check I am not 100 % sure about my understanding of this check. |
|
looks good, Thanks for this! |
|
cheers ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…size #613
-added auto split feature
-new signal split-auto was added
-currently this uses widget dimensions for the split as rows, cols were having different space and was not consistent, this can be changed if needed -short cut was also added
Note: -icon for the menu item needs to be added (since I am not aware of graphics & UI process)