Remove all ibus workarounds #674
Conversation
I am sick of ibus breaking every single time we issue a new release, so as of now, I've gone through the code and removed all of the workarounds that we have put in to try and get around issues in ibus, and GTK Input Methods in general. The code as it stands should work, I'm going to mention a bunch of people in this PR and ask them to beta test this change.
|
The following is a list of users that have seen issues with GTK input methods and Terminators. Can I ask anyone receiving this message, or anyone else interested to test out the change
Then once you've checked out the relevant code:
@mjw10086 |
|
On ubuntu 18.04: |
about automatic testingon ubuntu22, x11 (not sure on wayland, maybe not work) this cmd can focus terminator window, and simulate keyboard input 'abc' xdotool search --onlyvisible --all terminator windowactivate windowfocus sleep 0.5 type 'abc'
xdotool search --onlyvisible --class terminator windowactivate --sync windowfocus --sync type 'abc'// I don't know if there is an existing test platform |
|
on ubuntu 22 lts, x11, the test steps got this test result:
//seems got doubles characters |
|
have to say even with those hacks $ apt list -a terminator
terminator/jammy,jammy,now 2.1.1-1 all [installed]
$ GTK_IM_MODULE= IBUS_DISABLE_SNOOPER=1 /usr/bin/terminator -uunless I stop ibus by once ibus come back, it brings back the double char |
@yurenchen000 How are you setting up ibus with the en input method? I added en_US keyboard through ibus-setup but that didn't seem to make a difference. |
|
ibus with |
|
I see. That seems to be a problem only with that input method. I tried installing a bunch of other keyboards and they all worked as expected, and even worse, it doesn't even need to be on that keyboard, it just has to have the plugin installed. Can you open an issue with them? I have no idea why this is happening, but ibus-libpinyin seems to cause doubled characters in a bunch of different applications and programs. https://github.com/libpinyin/ibus-libpinyin |
I'm not sure source cause is that ibus-libpinyin. another input method
chen@u22:~$ apt list ibus-table-wubi
ibus-table-wubi/jammy,jammy,now 1.8.2-3 all [installed]
chen@u22:~$ dpkg -L ibus-table-wubi
/usr/share/ibus-table/icons/wubi-haifeng86.svg
/usr/share/ibus-table/icons/wubi-jidian86.svg
/usr/share/ibus-table/tables/wubi-haifeng86.db
/usr/share/ibus-table/tables/wubi-jidian86.db
chen@u22:~$ pgrep -af table
97023 /usr/bin/python3 /usr/share/ibus-table/engine/main.py --ibusthe issue disapper only if I do all those operations:
// with / without restart terminator no effect I will try more & report to them later |
|
@yurenchen000 thank you for doing all this digging. We can definitely look at opening a bug against ibus itself, but given that very few input methods actually trigger this behaviour, I'm thinking it's something that those input methods in particular are doing. The reason I asked you to open a bug against the ibus-libpinyin library in particular was mostly because all the issues were in Chinese and I didn't understand any of them, so it was hard for me to see if there were any similar issues. |
|
If it's still useful, it works for me (no duplicated broadcast): BUT I'm not sure I'm still using ibus. Maybe I removed it at some point in the last year, can't remember: The execution of the terminator command throws the following Warning: Edit: I've installed ibus to test this. Launched with Input methods available: ES (Spanish) and EN (English US). It does the double broadcast. On another console, close ibus with |
|
Alas, still doubling broadcast output. Fedora 35, Wayland 1.20.0, Plasma 5.25.4 desktop, plain English (US):
|
|
I'd like to give some feedback, too. System looks like this: ** (terminator:12324): WARNING **: 10:35:44.515: Binding 'a' failed! $ echo $QT_IM_MODULE |
@PenelopeFudd Can you list the output of Also, I'm surprised to see this because fedora 35 on wayland is basically my development environment, and I've never run into it there. |
@xbello Interesting, we know this module causes problems, and likely ibus-hangul as well. |
I'm trying to reproduce in my second PC, which is almost the same as the previous one, and double broadcast is gone. Revelant env: Installed: Maybe solved in ibus-gtk4 ? I'm lost. |
|
|
Thanks for the feedback everyone. At least now I can reproduce the problem, and know of what usually causes it. |
|
I've tested the patch, There is no duplicating problem, and the group broadcasting seems fine without activating fcitx(input application like ibus) or fcitx input language is set to English. But the group broadcasting malfunctioned when inputting CJK characters using fcitx(see the attached screenshot). |
|
I've just tested it, but it's still doing double-input for me. |
Make sure there are no running terminator instances before running terminator, or run |
|
Or |
That will not work. Unless you specify to disable dbus using -u, trying to start a new instance of terminator will attach to an already running instance. |
|
Ok, |
|
@PenelopeFudd F37 is out and it has a new version of IBus that may fix this. F35 is coming EOL in a month or so. |
|
Have terminator 2.1.1 in ubuntu 22.04.3. But bug with double input is still here ((( |
|
Thanks I've done as you said here and no more double keystrokes, thanks a lot!
|
|
I am sick of ibus breaking every single time we issue a new release, so as of now, I've gone through the code and removed all of the workarounds that we have put in to try and get around issues in ibus, and GTK Input Methods in general.
The code as it stands should work, I'm going to mention a bunch of people in this PR and ask them to beta test this change.