Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better distinguishing of inactive windows from the active one, by changing the background brightness #709

Merged
merged 6 commits into from Mar 1, 2023

Conversation

KKoovalsky
Copy link
Contributor

Hello!

I normally don't use title bar, thus differentiation between active and inactive windows, when there is not much in the foreground, is hard for me.

To better explain this, check out this GIF - the problem:

When there is not much data on the terminals, then it's hard to distinguish in which terminal I'm currently writing.

With this PR, one can change the background brightness of the Inactive window:

I have introduced a setting which allows changing the background brightness of the inactive window:

This PR introduces changes to the background color, and the implementation is a simple copy-pasted solution, scrapped from the inactive_color_offset, which controls the brightness of the font for an inactive window.

At this stage, it is a draft, because I have few questions:

  1. Do you find it good?
  2. Should I update the translations as well, since a new text within the "Preferences" window is introduced? Even, when I generate the translation script from the upstream/master, I get a non-null git diff. Therefore, I am "afraid" of putting the updated to the PR.

Normally, one can only change the background of the foreground for the
inactive window. With this change the background of the inactive window
will also change it's brightness by 20%.
Copy link
Member

@Vulcalien Vulcalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as intended, great!
It's a feature that should obviously be present.

The only thing to consider is if the default should be 80% (as it is in the PR) or 100% (current behavior).

In preferences.glade some widgets got shuffled by the tool. That might create some conflicts with other PRs.

@KKoovalsky
Copy link
Contributor Author

Cool, that it can be introduced!

I have changed the default value to 100%.

Regarding the preferences.glade, what can I do to fix it?

@mattrose
Copy link
Member

mattrose commented Mar 1, 2023

It's been a bit since I touched that code, but how does it work with transparent or image backgrounds? Does it just set the bgcolor to black? Can you try this out?

@mattrose
Copy link
Member

mattrose commented Mar 1, 2023

I gave it a shot with both transparent and image backgrounds and it doesn't seem to work.

This is ... not entirely unexpected, and honestly, it's probably fine, as the unfocussed code is going to be re-written at some point in the GTK4 process anyways. I have some ideas on how to fix this, but that way lies madness.

@mattrose
Copy link
Member

mattrose commented Mar 1, 2023

Anyway, that said, I'm fine with this if you are.

@mattrose mattrose marked this pull request as ready for review March 1, 2023 21:43
@mattrose mattrose merged commit 380be99 into gnome-terminator:master Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants