Merge pull request #36 from alice-si/ensure-more-than-one-outcome-slot

Add validation requiring more than one outcome
gnosis · Jul 9, 2019 · 75369ea · 75369ea
2 parents a982033 + a149d87
commit 75369ea
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/contracts/PredictionMarketSystem.sol b/contracts/PredictionMarketSystem.sol
@@ -65,7 +65,7 @@ contract PredictionMarketSystem is OracleConsumer, ERC1155 {
     /// @param outcomeSlotCount The number of outcome slots which should be used for this condition. Must not exceed 256.
     function prepareCondition(address oracle, bytes32 questionId, uint outcomeSlotCount) external {
         require(outcomeSlotCount <= 256, "too many outcome slots");
-        require(outcomeSlotCount > 0, "no outcome slots provided");
+        require(outcomeSlotCount > 1, "there should be more than one outcome slot");
         bytes32 conditionId = keccak256(abi.encodePacked(oracle, questionId, outcomeSlotCount));
         require(payoutNumerators[conditionId].length == 0, "condition already prepared");
         payoutNumerators[conditionId] = new uint[](outcomeSlotCount);

diff --git a/test/test_pm_system.js b/test/test_pm_system.js
@@ -38,13 +38,20 @@ contract("PredictionMarketSystem", function(accounts) {
     );
   });
 
-  it("should not be able to prepare a condition with no outomes slots", async () => {
+  it("should not be able to prepare a condition with no outcome slots", async () => {
     await assertRejects(
       predictionMarketSystem.prepareCondition(oracle, questionId, 0),
       "Transaction should have reverted."
     );
   });
 
+  it("should not be able to prepare a condition with just one outcome slots", async () => {
+    await assertRejects(
+      predictionMarketSystem.prepareCondition(oracle, questionId, 1),
+      "Transaction should have reverted."
+    );
+});
+
   it("should have obtainable conditionIds if in possession of oracle, questionId, and outcomeSlotCount", async () => {
     assert.equal(
       (await predictionMarketSystem.getOutcomeSlotCount(conditionId)).valueOf(),