Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

2139/claim identicon #2161

Merged
merged 2 commits into from Jan 15, 2022
Merged

2139/claim identicon #2161

merged 2 commits into from Jan 15, 2022

Conversation

alfetopito
Copy link
Contributor

Summary

Closes #2139

Using the identicon
Screen Shot 2022-01-14 at 16 24 51

To Test

  1. On claim page, check different wallets and observe the identicon changing for each of them

@alfetopito alfetopito self-assigned this Jan 15, 2022
@alfetopito alfetopito requested a review from a team January 15, 2022 00:25
@github-actions
Copy link
Contributor

  • 🔭 GP Swap: Gnosis Protocol v2 Swap UI

@W3stside W3stside merged commit 4c41c57 into claim Jan 15, 2022
@W3stside W3stside deleted the 2139/claim-identicon branch January 15, 2022 10:42
Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE

@elena-zh
Copy link

Great!

@fairlighteth
Copy link
Contributor

@alfetopito Tuning in here: I'd personally stick to the 'blockies' avatar for all wallets:

  • We can't detect the MetaMask setting the users has (e.g. you can enable/disable blockies in settings). So even with MM users there's a potential mismatch.
  • All other external block explorers/wallet managers use Blockies (Etherscan, Zerion, Gnosis Safe, Zapper, etc.).

@alfetopito
Copy link
Contributor Author

@alfetopito Tuning in here: I'd personally stick to the 'blockies' avatar for all wallets:

* We can't detect the MetaMask setting the users has (e.g. you can enable/disable blockies in settings). So even with MM users there's a potential mismatch.

* All other external block explorers/wallet managers use Blockies (Etherscan, Zerion, Gnosis Safe, Zapper, etc.).

Is that something we have in the app already?

I picked the first one I saw used, otherwise we'd need to add a new component/api/lib/etc

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants