Feature/pm 572 add new role admin #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
denisgranha
commented
Apr 6, 2018
denisgranha
commented
- Added isPlayToken constant
- new role admin
- updated addresses
- migration script accepts parameter admins
- added issuance script
denisgranha
force-pushed
the
feature/PM-572-add-new-role-admin
branch
from
bd982f2
to
08fed7e
Compare
cag
approved these changes
Apr 6, 2018
| @@ -43,6 +43,8 @@ Then run: | |||
| npm install | |||
| npm run compile | |||
| npm run migrate -- --network rinkeby | |||
| # if you want to deploy the markets with another account (recommended), you will need to add those accounts as admins | |||
| npm run migrate -- --network rinkeby --admins=address1,...,address2 (comma separated) | |||
There was a problem hiding this comment.
I wonder if we should throw the --reset flag in there as well: I think I had to do so when deploying to Rinkeby.
Also, this means that GnosisDB should be set up before setting up these contracts in Apollo, right?
There was a problem hiding this comment.
Yeah, the first step should be create the contracts, then set up GnosisDB
|
|
||
| # Issue tokens | ||
| ```sh | ||
| truffle exec scripts/issue_tokens.js --network=rinkeby --amount 1e18 --to <comma separated addresses> |
There was a problem hiding this comment.
I should really use truffle exec more...
There was a problem hiding this comment.
Yeah, I just discovered today, wanted to add this command here, I think it's useful, we can add also another one for allowTransfers and addAdmin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.