Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #354: Update asset overview screen #360

Merged
merged 9 commits into from
May 13, 2019

Conversation

elgatovital
Copy link
Contributor

Update asset overview screen #354

Changes proposed in this pull request:

  • Remove send/receive buttons
  • Tapping the identicon or the address brings up the receive screen.
  • Tapping "Add token" brings up the manage tokens screen.
  • Tapping an asset will start the send transaction flow.
  • All amounts are formatted as short amount

see https://github.com/gnosis/safe/blob/master/specs/assets_overview/02_user_interface.rst

@gnosis/mobile-devs

@rmeissner rmeissner changed the title Feature/issue 354 update asset overview screen Closes #354: Update asset overview screen May 13, 2019
Copy link
Member

@rmeissner rmeissner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only checked the code, did not check how the layout looks

@codecov-io
Copy link

codecov-io commented May 13, 2019

Codecov Report

Merging #360 into master will decrease coverage by 0.02%.
The diff coverage is 17.39%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #360      +/-   ##
===========================================
- Coverage     35.33%   35.3%   -0.03%     
  Complexity      446     446              
===========================================
  Files           239     240       +1     
  Lines          7084    7090       +6     
  Branches       1025    1027       +2     
===========================================
  Hits           2503    2503              
- Misses         4354    4358       +4     
- Partials        227     229       +2
Impacted Files Coverage Δ Complexity Δ
...imdall/ui/tokens/balances/TokenBalancesFragment.kt 0% <ø> (ø) 0 <0> (ø) ⬇️
...m/gnosis/heimdall/ui/safe/main/SafeMainActivity.kt 1.61% <ø> (+0.01%) 0 <0> (ø) ⬇️
...is/heimdall/ui/safe/details/SafeDetailsContract.kt 100% <ø> (ø) 1 <0> (ø) ⬇️
...s/heimdall/ui/safe/details/SafeDetailsViewModel.kt 58.33% <0%> (-29.17%) 4 <0> (ø)
...eimdall/ui/tokens/balances/TokenBalancesAdapter.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...is/heimdall/ui/safe/details/SafeDetailsFragment.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...is/heimdall/data/repositories/models/ERC20Token.kt 70.58% <0%> (-5.89%) 9 <1> (ø)
...n/java/pm/gnosis/heimdall/helpers/AddressHelper.kt 100% <100%> (ø) 3 <0> (ø) ⬇️
.../gnosis/heimdall/ui/safe/main/SafeMainViewModel.kt 93.33% <100%> (ø) 15 <1> (ø) ⬇️
...ctions/view/viewholders/AssetTransferViewHolder.kt 85.18% <100%> (ø) 15 <0> (ø) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2188157...f8e61c7. Read the comment docs.

- extract functionality for ellipsizing address string
- calculate address checksum string on a worker thread
- add to disposables
@elgatovital elgatovital self-assigned this May 13, 2019
@elgatovital elgatovital added this to the android-safe-1.4.0 milestone May 13, 2019
@elgatovital elgatovital merged commit 06bc7d3 into master May 13, 2019
@elgatovital elgatovital deleted the feature/issue_354_update_asset_overview_screen branch May 13, 2019 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants