-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #354: Update asset overview screen #360
Closes #354: Update asset overview screen #360
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only checked the code, did not check how the layout looks
app/src/main/java/pm/gnosis/heimdall/ui/safe/details/SafeDetailsFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/pm/gnosis/heimdall/ui/safe/details/SafeDetailsFragment.kt
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #360 +/- ##
===========================================
- Coverage 35.33% 35.3% -0.03%
Complexity 446 446
===========================================
Files 239 240 +1
Lines 7084 7090 +6
Branches 1025 1027 +2
===========================================
Hits 2503 2503
- Misses 4354 4358 +4
- Partials 227 229 +2
Continue to review full report at Codecov.
|
- extract functionality for ellipsizing address string - calculate address checksum string on a worker thread
- add to disposables
Update asset overview screen #354
Changes proposed in this pull request:
see https://github.com/gnosis/safe/blob/master/specs/assets_overview/02_user_interface.rst
@gnosis/mobile-devs