Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gas token #24

Merged
merged 1 commit into from
Nov 7, 2018
Merged

Gas token #24

merged 1 commit into from
Nov 7, 2018

Conversation

Uxio0
Copy link
Member

@Uxio0 Uxio0 commented Nov 7, 2018

Resolves #18

@coveralls
Copy link

Pull Request Test Coverage Report for Build 393

  • 141 of 148 (95.27%) changed or added relevant lines in 14 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.6%) to 88.653%
Changes Missing Coverage Covered Lines Changed/Added Lines %
safe_relay_service/relay/views.py 22 25 88.0%
safe_relay_service/tokens/models.py 20 24 83.33%
Totals Coverage Status
Change from base Build 387: 0.6%
Covered Lines: 1297
Relevant Lines: 1463
💛 - Coveralls

@Uxio0
Implement gas token support
3e03b2d 
- Create DB model and add migrations
- Fix estimate/send tx view
- Calculate token gas price based on ether
- Update gnosis-py version
- Fix signatures (allow v to be 0 and 1)
@Uxio0 Uxio0 merged commit 788b0ab into develop Nov 7, 2018
@Uxio0 Uxio0 deleted the gas-token branch November 7, 2018 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Uxio0 @coveralls