Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support GasToken for sending tx #18

Closed
Uxio0 opened this issue Oct 25, 2018 · 0 comments
Closed

Support GasToken for sending tx #18

Uxio0 opened this issue Oct 25, 2018 · 0 comments
Assignees
@Uxio0
Labels
enhancement New feature or request

Comments

@Uxio0
Copy link
Member

Uxio0 commented Oct 25, 2018

GasToken support for sending txs would be desired:

  • Estimation endpoint must receive now the gasToken, and calculate gasPrice using the Ether value of the token.
  • Then on the sending tx endpoint gasToken can be used. Value of the gasPrice will be checked to make sure that service is not loosing Eth.
@Uxio0 Uxio0 added the enhancement New feature or request label Oct 25, 2018
@Uxio0 Uxio0 self-assigned this Oct 25, 2018
@Uxio0 Uxio0 mentioned this issue Oct 25, 2018
Closed
@Uxio0 Uxio0 mentioned this issue Nov 7, 2018
Merged
Uxio0 added a commit that referenced this issue Nov 7, 2018
@Uxio0
Merge pull request #24 from gnosis/gas-token
788b0ab 
Resolves #18
@Uxio0 Uxio0 closed this as completed Nov 7, 2018
@Uxio0 Uxio0 mentioned this issue Nov 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Uxio0 Uxio0

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Uxio0