Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration mainnet #8

Merged
merged 10 commits into from
Dec 11, 2019
Merged

Migration mainnet #8

merged 10 commits into from
Dec 11, 2019

Conversation

josojo
Copy link
Contributor

@josojo josojo commented Dec 11, 2019

  • migrated newly on mainnet and rinkeby
  • npm version update

@fleupold
Copy link
Contributor

Can you rebase this on top of the previous PR so that only the changes of this PR show. Also would you mind explaining why we need migration_conf.js and how concretely this was deployed? Also I don't see a networks.json. Do we not use this one?
It's a bit annoying having to deploy both at the same time if we cannot reproduce the deployment addresses.

@josojo josojo changed the base branch from master to deploymentTools December 11, 2019 16:34
@josojo
Copy link
Contributor Author

josojo commented Dec 11, 2019

Sorry @fleupold ...

I added the missing networks.json, I forgot to git add it.

It's a bit annoying having to deploy both at the same time if we cannot reproduce the deployment addresses.

Yes, this is why I was introducing the networks.json. Now we have it cleaned up :)

fleupold
fleupold approved these changes Dec 11, 2019
View reviewed changes
Copy link
Contributor

@fleupold fleupold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@josojo josojo changed the base branch from deploymentTools to master December 11, 2019 18:15
@josojo josojo merged commit 6acd9e1 into master Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fleupold fleupold fleupold approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@josojo @fleupold