OOG invalidates proposal #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmeissner
commented
Mar 7, 2021
auryn-macmillan
approved these changes
Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will require the module transaction to be successfull and add the possibility to set an expiration time for the answer.
For more details on why this is done see below.
Problem
A malicious executor could send to little gas that would then mark that particular transaction as executed even so internally it failed because there was not enough gas available. This potentially prevents execution of proposals.
See https://github.com/gnosis/dao-module/blob/main/contracts/DaoModule.sol#L220
Solutions
Tx gasAdd a "gas" value to the transactions, that set a minimum of required gas for each transactions. If the transaction fails (no matter why) it will still me marked as executed. Following transactions in the array will be able to be executed, but it will not possible to retry the failed transaction.Never fail
Require that the module transaction did not fail. This will prevent the execution of other tx in the array and the tx will not be marked as executed. Unless the proposal is invalidated it is possible to retry the transaction (at any point in time).
-> This bring up the question if a tx/ proposal should have a deadline for execution.