Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: core networks for osnap #157

Merged
merged 7 commits into from
Feb 26, 2024

Conversation

Reinis-FRP
Copy link
Contributor

@Reinis-FRP Reinis-FRP commented Feb 7, 2024

Add a feature

Feature Request

Add support of UMA oSnap modules on Core networks (https://coredao.org/)

Implementation

Add support by deploying module proxy factory and oSnap module mastercopy on Core mainnet/testnet

Additional Context

Also added hardhat config and ran deploy scripts:

coreTestnet
    realityETH
  βœ” Mastercopy deployed to:        0x4e35DA39Fa5893a70A40Ce964F993d891E607cC0 πŸŽ‰ 
    realityERC20
  βœ” Mastercopy deployed to:        0x7276813b21623d89BA8984B225d5792943DD7dbF πŸŽ‰ 
    bridge
  βœ” Mastercopy deployed to:        0x03B5eBD2CB2e3339E93774A1Eb7c8634B8C393A9 πŸŽ‰ 
    delay
  βœ” Mastercopy deployed to:        0xd54895B1121A2eE3f37b502F507631FA1331BED6 πŸŽ‰ 
    exit
  βœ” Mastercopy deployed to:        0x3ed380a282aDfA3460da28560ebEB2F6D967C9f5 πŸŽ‰ 
    exitERC721
  βœ” Mastercopy deployed to:        0xE0eCE32Eb4BE4E9224dcec6a4FcB335c1fe05CDe πŸŽ‰ 
    circulatingSupplyERC20
  βœ” Mastercopy deployed to:        0x5Ed57C291a184cc244F5c9B5E9F11a8DD08BBd12 πŸŽ‰ 
    circulatingSupplyERC721
  βœ” Mastercopy deployed to:        0xBD34D00dC0ae37C687F784A11FA6a0F2c5726Ba3 πŸŽ‰ 
    scopeGuard
  βœ” Mastercopy deployed to:        0xeF27fcd3965a866b22Fb2d7C689De9AB7e611f1F πŸŽ‰ 
    factory
  βœ” Mastercopy already deployed to: 0x000000000000aDdB49795b0f9bA5BC298cDda236
    roles
  βœ” Mastercopy deployed to:        0xD8DfC1d938D7D163C5231688341e9635E9011889 πŸŽ‰ 
    roles_v1
  βœ” Mastercopy already deployed to: 0xD8DfC1d938D7D163C5231688341e9635E9011889
    roles_v2
  βœ” Mastercopy already deployed to: 0x9646fDAD06d3e24444381f44362a3B0eB343D337
    ozGovernor
  βœ” Mastercopy deployed to:        0xe28c39FAC73cce2B33C4C003049e2F3AE43f77d5 πŸŽ‰ 
    erc20Votes
  βœ” Mastercopy deployed to:        0x752c61de75ADA0F8a33e048d2F773f51172f033e πŸŽ‰ 
    erc721Votes
  βœ” Mastercopy deployed to:        0xeFf38b2eBB95ACBA09761246045743f40e762568 πŸŽ‰ 
    multisendEncoder
  βœ” Mastercopy deployed to:        0xb67EDe523171325345780fA3016b7F5221293df0 πŸŽ‰ 
    permissions
  βœ” Mastercopy deployed to:        0x33D1C5A5B6a7f3885c7467e829aaa21698937597 πŸŽ‰ 
    connext
  βœ” Mastercopy deployed to:        0x7dE07b9De0bf0FABf31A188DE1527034b2aF36dB πŸŽ‰ 

and

core
    realityETH
  βœ” Mastercopy deployed to:        0x4e35DA39Fa5893a70A40Ce964F993d891E607cC0 πŸŽ‰ 
    realityERC20
  βœ” Mastercopy deployed to:        0x7276813b21623d89BA8984B225d5792943DD7dbF πŸŽ‰ 
    bridge
  βœ” Mastercopy deployed to:        0x03B5eBD2CB2e3339E93774A1Eb7c8634B8C393A9 πŸŽ‰ 
    delay
  βœ” Mastercopy deployed to:        0xd54895B1121A2eE3f37b502F507631FA1331BED6 πŸŽ‰ 
    exit
  βœ” Mastercopy deployed to:        0x3ed380a282aDfA3460da28560ebEB2F6D967C9f5 πŸŽ‰ 
    exitERC721
  βœ” Mastercopy deployed to:        0xE0eCE32Eb4BE4E9224dcec6a4FcB335c1fe05CDe πŸŽ‰ 
    circulatingSupplyERC20
  βœ” Mastercopy deployed to:        0x5Ed57C291a184cc244F5c9B5E9F11a8DD08BBd12 πŸŽ‰ 
    circulatingSupplyERC721
  βœ” Mastercopy deployed to:        0xBD34D00dC0ae37C687F784A11FA6a0F2c5726Ba3 πŸŽ‰ 
    scopeGuard
  βœ” Mastercopy deployed to:        0xeF27fcd3965a866b22Fb2d7C689De9AB7e611f1F πŸŽ‰ 
    factory
  βœ” Mastercopy already deployed to: 0x000000000000aDdB49795b0f9bA5BC298cDda236
    roles
  βœ” Mastercopy deployed to:        0xD8DfC1d938D7D163C5231688341e9635E9011889 πŸŽ‰ 
    roles_v1
  βœ” Mastercopy already deployed to: 0xD8DfC1d938D7D163C5231688341e9635E9011889
    roles_v2
  βœ” Mastercopy already deployed to: 0x9646fDAD06d3e24444381f44362a3B0eB343D337
    ozGovernor
  βœ” Mastercopy deployed to:        0xe28c39FAC73cce2B33C4C003049e2F3AE43f77d5 πŸŽ‰ 
    erc20Votes
  βœ” Mastercopy deployed to:        0x752c61de75ADA0F8a33e048d2F773f51172f033e πŸŽ‰ 
    erc721Votes
  βœ” Mastercopy deployed to:        0xeFf38b2eBB95ACBA09761246045743f40e762568 πŸŽ‰ 
    multisendEncoder
  βœ” Mastercopy deployed to:        0xb67EDe523171325345780fA3016b7F5221293df0 πŸŽ‰ 
    permissions
  βœ” Mastercopy deployed to:        0x33D1C5A5B6a7f3885c7467e829aaa21698937597 πŸŽ‰ 
    connext
  βœ” Mastercopy deployed to:        0x7dE07b9De0bf0FABf31A188DE1527034b2aF36dB πŸŽ‰ 

This PR also fixes couple of syntax errors so that above deployment tasks can be performed

Signed-off-by: Reinis Martinsons <reinis@umaproject.org>
Signed-off-by: Reinis Martinsons <reinis@umaproject.org>
Signed-off-by: Reinis Martinsons <reinis@umaproject.org>
Copy link

github-actions bot commented Feb 7, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ βœ…

@Reinis-FRP
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@auryn-macmillan
Copy link
Collaborator

auryn-macmillan commented Feb 7, 2024

Thanks for the PR, @Reinis-FRP. Could you please also add Core Network and Core Network Testnet to the list of networks in hardhat.config.ts and confirm that the deploy script listed in package.json works on Core Network and Core Network Testnet?

Signed-off-by: Reinis Martinsons <reinis@umaproject.org>
Signed-off-by: Reinis Martinsons <reinis@umaproject.org>
Signed-off-by: Reinis Martinsons <reinis@umaproject.org>
@Reinis-FRP
Copy link
Contributor Author

Thanks for the PR, @Reinis-FRP. Could you please also add Core Network and Core Network Testnet to the list of networks in hardhat.config.ts and confirm that the deploy script listed in package.json works on Core Network and Core Network Testnet?

Sure, I added config to hardhat.config.ts and confirmed the deploy script works. Though I needed to fix couple of syntax errors related to this script that I added to this PR.

Also one issue with deployment was that ROLES_V2 mastercopy deployment is reverting on Core, so singletonFactory.deploy.staticCall returns zero address and the script assumes ROLES_V2 is already deployed.

@Reinis-FRP
Copy link
Contributor Author

The above issue with ROLES_V2 is not a blocker for oSnap, so this can be merged. @auryn-macmillan , let me know if there are any concerns on this

Copy link
Collaborator

@auryn-macmillan auryn-macmillan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@auryn-macmillan auryn-macmillan merged commit 7bfaef6 into gnosisguild:master Feb 26, 2024
1 check passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants