Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Html: Add indicator to show if page is from HTML databases or Wikitext databases #525

Open
gnosygnu opened this issue Jul 30, 2019 · 7 comments

Comments

@gnosygnu
Copy link
Owner

Per #388, an indicator can clearly show if a page is from HTML databases or Wikitext databases

I think the following would be involved:

  • Find icons / html to designate HTML or WIKITEXT
  • Find a spot on the page to put it (sidebar? other indicators? upper right? near read-edit-view_html?)
  • Add an option to disable the indicator (and possibly to customize it)
@desb42
Copy link
Collaborator

desb42 commented Aug 1, 2019

I have put together some code to show the text HTML or WIKITEXT as appropriate
Please see my branch page_mode

html_flag
wikitext_flag

What do you think?

@gnosygnu gnosygnu added this to To do in A <div> in D Aug 2, 2019
@gnosygnu
Copy link
Owner Author

gnosygnu commented Aug 2, 2019

Looked quickly at desb42@6804f49 but looks good.

Added it to todo. Will be done after #529

Thanks!

@gnosygnu
Copy link
Owner Author

Added enhancement with commit above.

Essentially the same as your commit. Also added ability to customize HTML at home/wiki/Special:XowaCfg?grp=xowa.wiki.hdumps

Thanks again for suggestion!

@gnosygnu gnosygnu moved this from To do to Done in A <div> in D Aug 10, 2019
@desb42
Copy link
Collaborator

desb42 commented Aug 12, 2019

nice idea about configuration

I think a mod to xowa.gfs is necessary

gnosygnu added a commit that referenced this issue Aug 15, 2019
@gnosygnu
Copy link
Owner Author

Oops. Missed the xowa.gfs. Added it just now.

Hope it works for you. Thanks again for the commit!

@desb42
Copy link
Collaborator

desb42 commented Aug 22, 2019

I have now started to compare the hdump and wikitext generation of pages

At the moment it is cumbersome to switch between these two modes
As it is necessary to go into Options and change 'Prefer HTML Databases for Read tab'

To make this easier for me, I have enhanced the behaviour of the HTML/WIKITEXT display

The first change is to indicate which display mode is set (by the use of bold)
The second change was to make these links to the other display mode (to do this I needed to introduce two more actions action=htmlver and action=wikitextver)

as an example taking simple.wikipedia.org/wiki/Wikipedia:About
sample1
The red ellipse shows HTML in bold (as this is the default setting of 'Prefer HTML Databases for Read tab'
The blue rectangle reads http://192.168.1.100/simple.wikipedia.org/wiki/Wikipedia:About?action=wikitextver
The orange ellipse shows a link in red (this seems to be a bug in the hdump version)

Clicking on the HTML link gives
sample2
The red ellipse shows WIKITEXT not in bold
The blue rectangle reads http://192.168.1.100/simple.wikipedia.org/wiki/Wikipedia:About?action=htmlver
The orange ellipse shows a a blue link (which is correct as this page does exist)

First . Should this be a separate 'issue'?
Second. Is this something to consider (or just ramblings)?

@gnosygnu gnosygnu removed this from Done in A <div> in D Aug 23, 2019
@gnosygnu gnosygnu added this to To do in A <div> in D Aug 23, 2019
@gnosygnu
Copy link
Owner Author

Cool! Nice feature implementation on your side!

First . Should this be a separate 'issue'?

Keeping it under this issue is fine. Easier to have discussion centralized

Second. Is this something to consider (or just ramblings)?

The idea sounds great and I'll probably end up wanting the same thing.

I've added it to todo for now. I think it's straightforward enough for me to implement, but feel free to post your commit if it's easy to do so.

Thanks!

@gnosygnu gnosygnu moved this from To do to In progress in A <div> in D Aug 27, 2019
@gnosygnu gnosygnu moved this from In progress to To do in A <div> in D Sep 8, 2019
@gnosygnu gnosygnu moved this from To do to Triage in A <div> in D Mar 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
A <div> in D
  
Triage
Development

No branches or pull requests

2 participants