Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML_dump: Skip imgs with an empty src (<score> causing nullpointerexception) #577

Closed
desb42 opened this issue Sep 19, 2019 · 1 comment
Closed

Comments

@desb42
Copy link
Collaborator

desb42 commented Sep 19, 2019

I have managed to produce a full build of enwiki (including html)
I have also added lillypond executable to provide <score> interpretation

This seems to have lead to an issue in the html version of en.wikipedia.org/wiki/Symphony_No._9_(Beethoven)

<java.lang.NullPointerException> null
[trace]:
  gplx.Io_mgr.ExistsFil(Unknown Source)
  gplx.xowa.htmls.core.Xow_hdump_mgr__load.Fill_page(Unknown Source)
  gplx.xowa.htmls.core.Xow_hdump_mgr__load.Load_by_xowe(Unknown Source)

it seems that the html generated has text of the form

<p>
  <a id="xowa_score_0_a" href="" xowa_title="">
    <img id="xowa_score_0_img" src=""  />
  </a>
</p>

by adding

if (itm.Orig_ttl() == null) continue;

at line 129 of 400_xowa\src\gplx\xowa\htmls\core\Xow_hdump_mgr__load.java it loads the page without error

@gnosygnu
Copy link
Owner

gnosygnu commented Oct 2, 2019

Thanks for the simple fix! Corrected with the commit above!

@gnosygnu gnosygnu moved this from To do to Done in A <div> in D Oct 2, 2019
@gnosygnu gnosygnu changed the title <score> causing nullpointerexception HTML_dump: Skip imgs with an empty src (<score> causing nullpointerexception) Oct 2, 2019
gnosygnu added a commit that referenced this issue Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
A <div> in D
  
Done
Development

No branches or pull requests

2 participants