Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scribunto: Cache results of title.exists (missing images slow page load) #597

Closed
desb42 opened this issue Oct 14, 2019 · 3 comments
Closed

Comments

@desb42
Copy link
Collaborator

desb42 commented Oct 14, 2019

Although I thought that I have built a version where all the image have been downloaded and added to the 'file' databases, the page en.wiktionary.org/wiki/網 takes time to load

This is due to the fact that on requesting the page, 6 images fail to download

download_failed: 網-bronze-spring.svg
download_failed: 網-odd.svg
download_failed: 網-vulgar.svg
download_failed: 網-bigseal.svg
download_failed: 網-clerical.svg
download_failed: ACC-s05493.svg

These images do not exist - but every time the page is loaded these six images will be requested

This is due to the Module:zh-glyph which is cycling through a pattern of images for this page, some of which may not exist (in this case 6 but I have seen more failures on other pages of Chinese characters)

I think this is an instance where the failures should be noted, so that the page could/should load faster

@gnosygnu
Copy link
Owner

Cool. Thanks for the detail.

The page loads quickly on my end, but I'm guessing that's because I have an SSD? Regardless, as you pointed out, the Scribunto Title.exists call should be using cached data. I added it with the commit above.

Let me know if any issues. Thanks!

@gnosygnu gnosygnu changed the title missing images slow page load Scribunto: Cache results of title.exists (missing images slow page load) Nov 18, 2019
@gnosygnu gnosygnu moved this from Triage to Done in A <div> in D Nov 18, 2019
@desb42
Copy link
Collaborator Author

desb42 commented Nov 19, 2019

This problem manifests when generating from wikitext (the hdump version does not seem to be affected)
As I have a slow internet connection, this probably exacerbates it

@gnosygnu
Copy link
Owner

Makes sense. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment