Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special:Search results display is blank for enwikt #606

Closed
desb42 opened this issue Oct 22, 2019 · 6 comments
Closed

Special:Search results display is blank for enwikt #606

desb42 opened this issue Oct 22, 2019 · 6 comments

Comments

@desb42
Copy link
Collaborator

desb42 commented Oct 22, 2019

One of the external links to en.wikiquote.org/wiki/United_Kingdom goes to enwiktionary with the link en.wiktionary.org/wiki/Special:Search/united_kingdom
Producing in xowa-gui

blank_results
There are no Page titles being displayed

I also noticed that if I change the link to en.wiktionary.org/wiki/Special:Search/United_Kingdom (capital U and capital K), then the page en.wiktionary.org/wiki/United_Kingdom is displayed directly (I assume this is the intended behaviour)

@desb42
Copy link
Collaborator Author

desb42 commented Oct 22, 2019

On further investigation I have found that the <a> anchor is being generated but with no visible text

The issue seems related to line 37 in 400_xowa\src\gplx\xowa\addons\wikis\searchs\specials\htmls\Srch_html_row_bldr.java
which reads

lnki_bldr.Caption_direct_(row.Page_ttl_display(Bool_.Y));

if I change this to

lnki_bldr.Caption_direct_(row.Page_ttl_display(Bool_.N));

The text appears (not really sure what the Bool_.Y is intending to do

@desb42
Copy link
Collaborator Author

desb42 commented Oct 22, 2019

And another small thing
Given that there are (in this example) only four results, why is a Next button displayed?

@gnosygnu gnosygnu added this to Triage in A <div> in D Oct 23, 2019
@gnosygnu gnosygnu moved this from Triage to To do in A <div> in D Oct 31, 2019
@gnosygnu gnosygnu changed the title Special:Search results display Special:Search results display is blank for enwikt Nov 12, 2019
@gnosygnu
Copy link
Owner

I'm having problems reproducing it, primarily because I don't have the fullTextSearch for enwikt and my openSuse box crashes with a heap dump after 5 or so hours. I may have to reinstall the OS, which could be painful...

@desb42
Copy link
Collaborator Author

desb42 commented Nov 12, 2019

I think that fullTextSearch refers to the lucene data generated by adding indexer_enabled = 'y' to the mass_parse step
If so, I have not created this data for my version of enwikt

This index used is being generated from the 'standard' step

search.page__page_score
search.link__link_score
search.word__link_count

@gnosygnu
Copy link
Owner

Yeah, sorry. fullTextSearch does refer to the indexer_enabled switch

I tried reproducing it on a regular build first, but didn't get any results. I did some more debugging today, and think I have a fix for this. I also fixed the blank empty rows (Regular search was basically broken)

I'll have a fix sometime tomorrow. Thanks

@gnosygnu
Copy link
Owner

Pushed commits above. Summary below.

Sorry again for delay, but things have been busy recently on personal level. Let me know if anything else. Thanks!


  • Regular search was showing empty results because it was always showing the highlighted title (highlighted title is specific to search suggest).
    • I fixed it by adding more specific logic as to which title to use
    • I also added some tests to try to guard against future breakage
  • Regular search (and probably full-text) would sometimes show empty results in xowa-gui (SWT) because the AJAX calls would return back faster than the GUI was ready (SWT was still loading the tab)
    • I fixed this by adding a simple flag to note when the GUI was done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
A <div> in D
  
Done
Development

No branches or pull requests

2 participants