Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Xtn.Pagebanner: Add extra space after hasPosition or some pageBanners will omit wpb-banner-image #618

Closed
gnosygnu opened this issue Nov 25, 2019 · 0 comments
Closed

Xtn.Pagebanner: Add extra space after hasPosition or some pageBanners will omit wpb-banner-image #618

gnosygnu opened this issue Nov 25, 2019 · 0 comments
Labels
core - parser [effort 5 - less than an hour] [priority 2 - major] [resolved - commit] [risk 4 - minor] [schedule 1 - within days] [type - bug]
Projects
A <div> in D

Comments

@gnosygnu
Copy link
Owner

Some pagebanners were showing an enlarged top-right hand corner of the image (Germany; United States of America).

This was because of a missing space in the mustache file, before the style attribute.

  • fail: class="wpb-banner-image"{{hasPosition}}...style="max-width:{{maxWidth}}px"
  • pass: class="wpb-banner-image"{{hasPosition}}... style="max-width:{{maxWidth}}px"

Because of the missing space, the XOWA HTML attribute parser would not pick up the preceding class attribute

Fixed in the commit below
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core - parser [effort 5 - less than an hour] [priority 2 - major] [resolved - commit] [risk 4 - minor] [schedule 1 - within days] [type - bug]
Projects
A <div> in D
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gnosygnu