parser: avoid character 0xff being interpreted as (int) -1

This fixes the following CVEs: - CVE-2021-46019 - CVE-2021-46022 - CVE-2021-46022 2022-04-16 Jose E. Marchesi <jemarch@gnu.org> CVE-2021-46019 CVE-2021-46022 CVE-2021-46022 * src/rec-parser.c (rec_parse_comment): Avoid 0xff being interpreted as (int) -1.
gnu-mirror-unofficial · Apr 16, 2022 · 34b75ed · 34b75ed
1 parent da55d49
commit 34b75ed
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/ChangeLog b/ChangeLog
@@ -1,3 +1,11 @@
+2022-04-16  Jose E. Marchesi  <jemarch@gnu.org>
+
+	CVE-2021-46019
+	CVE-2021-46022
+	CVE-2021-46022
+	* src/rec-parser.c (rec_parse_comment): Avoid 0xff being
+	interpreted as (int) -1.
+
 2022-04-16  Jose E. Marchesi  <jemarch@gnu.org>
 
 	* configure.ac: Remove algol68 bindings support.

diff --git a/src/rec-parser.c b/src/rec-parser.c
@@ -432,7 +432,7 @@ rec_parse_comment (rec_parser_t parser, rec_comment_t *comment)
                 c = '\n';
             }
 
-          if (rec_buf_putc (c, buf) == EOF)
+          if (rec_buf_putc (ci, buf) == EOF)
             {
               /* Out of memory */
               parser->error = REC_PARSER_ENOMEM;