Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

various fixes and additions #43

Merged
merged 1 commit into from Sep 25, 2022
Merged

various fixes and additions #43

merged 1 commit into from Sep 25, 2022

Conversation

acp29
Copy link
Contributor

@acp29 acp29 commented Sep 25, 2022

  • fixed bugs discussed in #60348 (updated after @NRJank's note)
  • added an optional output argument: a structure containing additional statistics
  • changed variables theta and beta to intercept and slope. Changed variable name for estimated probabilities from gamma to P
  • any rows in X or Y containing NaN (i.e. missing values) are automatically removed
  • private functions moved into logistic_regression as subfunctions (since they are not used by any other function in the statistics package)
  • Added BISTs

- fixed bugs discussed in #58318
- added an optional output argument: a structure containing additional statistics
- changed variables theta and beta to intercept and slope. Changed variable name for estimated probabilities from gamma to P
- any rows in X or Y containing NaN (i.e. missing values) are automatically removed
- private functions moved into `logistic_regression` as subfunctions (since they are not used by any other function in the statistics package)
- Added BISTs
@pr0m1th3as pr0m1th3as merged commit 47523cf into gnu-octave:main Sep 25, 2022
@NRJank
Copy link
Contributor

NRJank commented Sep 26, 2022

bug #58318 relates to "[octave forge] (statistics) "mnrfit" is missing". did you mean bug # 60348? the only mention I see of mnrfit is in the bists for matlab comparison tests.

also, still noticing a couple concerns with the function. will open up an Issue here rather than clutter up this comment or the mercurial bug tracker

@NRJank NRJank mentioned this pull request Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants