-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
isequal: failing with error: cell2mat: C must be a cell array #1221
Comments
Oh perhaps I misunderstand |
Simpler way to hit this:
|
In uniop_bool_helper:
Maybe this should be Or maybe just |
This function also uses linear indexing, similar to #1222. |
This routine is supposed to return a logical Octave array. Do linear indexing on the flattened tolist output which will work on both Array and Matrix. Fixes #1221.
------- Original Message -------
On Friday, September 2nd, 2022 at 5:03 PM, Colin B. Macdonald ***@***.***> wrote:
Simpler way to hit this:
>> t = sym(true)
>> w = [t t]
pydebug: make_matrix_or_array: making 2D Array...
pydebug: I am here with an array with shape (2, 1)
pydebug: make_matrix_or_array: making 2D Array...
pydebug: I am here with an array with shape (1, 2)
w = (sym) [[True True]] (1×2 matrix)
>> sympy(w)
ans = ImmutableDenseNDimArray(Tuple(true, true), Tuple(Integer(1), Integer(2)))
>> isequal(w, w)
error: cell2mat: C must be a cell array
error: called from
cell2mat at line 47 column 7
uniop_bool_helper at line 62 column 11
isnan at line 51 column 5
isequal at line 62 column 3
Interestingly, this error only occurs when we are using non-Pythonic IPC. To reproduce this error, one has to disable Pythonic IPC.
… >> isequal(t, t)
ans = 1
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
|
Fixed by #1224 |
------- Original Message -------
On Friday, September 2nd, 2022 at 5:03 PM, Colin B. Macdonald ***@***.***> wrote:
Simpler way to hit this:
>> t = sym(true)
>> w = [t t]
pydebug: make_matrix_or_array: making 2D Array...
pydebug: I am here with an array with shape (2, 1)
pydebug: make_matrix_or_array: making 2D Array...
pydebug: I am here with an array with shape (1, 2)
w = (sym) [[True True]] (1×2 matrix)
>> sympy(w)
ans = ImmutableDenseNDimArray(Tuple(true, true), Tuple(Integer(1), Integer(2)))
>> isequal(w, w)
error: cell2mat: C must be a cell array
error: called from
cell2mat at line 47 column 7
uniop_bool_helper at line 62 column 11
isnan at line 51 column 5
isequal at line 62 column 3
Interesting, this error only occurs when we are using non-Pythonic IPC. To reproduce this error, one has to disable Pythonic IPC.
… >> isequal(t, t)
ans = 1
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
|
This is based on a test from
@sym/and
, on the Array_not_Matrix branch:Note:
Looks like even after #1216, we're still getting Matrix from concatenate ops:
The text was updated successfully, but these errors were encountered: