Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relegate the on-close for emergencies #1175

Merged
merged 4 commits into from
Jul 5, 2022
Merged

Relegate the on-close for emergencies #1175

merged 4 commits into from
Jul 5, 2022

Commits on Jul 4, 2022

  1. private/python_ipc_popen2: Fixes warning after unloading package.

    This warning
    
    --8<---------------cut here---------------start------------->8---
    warning: onCleanup: error caught while executing cleanup function:
    'python_ipc_popen2_reset' undefined near line 78, column 30
      "'python_ipc_popen2_reset' undefined"
    --8<---------------cut here---------------end--------------->8---
    
    is caused by "pkg unload symbolic".
    
    We fix it by closing file descriptors and waitpid directly in the
    cleanup function instead of using private/python_ipc_popen2_reset.
    
    Fixes #1160.
    
    * inst/private/python_ipc_popen2.m: Close file descriptors and waitpid
    directly in the cleanup function.
    * inst/private/python_ipc_popen2_reset.m: Remove file.
    Alex Vong authored and Alex Vong committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    b39c768 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0495049 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    50799bb View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2022

  1. is_valid_file_id instead of not isempty

    Just in case the onCleanup triggers early and they have been closed
    or something.
    cbm755 committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    d300ea6 View commit details
    Browse the repository at this point in the history