-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We Like New Functions #526
Conversation
from travis:
D: |
moved the problem of cell2sym to #527 |
fix doctests
varargin should be always a sym
%% -*- texinfo -*- | ||
%% @documentencoding UTF-8 | ||
%% @defmethod @@sym charpoly (@var{x}) | ||
%% @defmethod @@sym charpoly (@var{x}, @var{y}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe A
and x
(or var
) are better names here? Can you also file an issue for the missing vector output?
print_usage (); | ||
end | ||
y = uniop_helper (x, 'lambda a: exp(-a**2)*erfi(a)*(sqrt(S(pi))/2)'); | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this needs a test, maybe something like:
octave:17> A = dawson([1 2])
A =
0.53808 0.30134
octave:18> B = double(dawson(sym([1 2])))
B =
0.53808 0.30134
octave:19> assert(A, B, -eps)
This looks great! Some minor comments above. I don't really understand your
If so, those should be tested (and I don't think it works right now). Or is it for something else? If easy, you could split off those functions and do a new PR and we can discuss. Then I can merge the other bits! |
move eye, ones, zeros to ther pr
okidokis, all proposed changes applied! zeros and similar to this pr #532. |
add seealso dawson
Hi again, well this time i have this functions, about the zero functions and related, i try avoid the most posible execute this line
y = sym(eye(cell2nosyms(varargin){:}));
, because this is fasteye(cell2nosyms(varargin){:})
, but transform that to sym takes to much time with big matrix.well other problem is, although i add the cell2sym function when i try execute it i get an error:
and actually divisors depends of it, if still don't works maybe at least add it to private.
This Fixes #405 and add some functions of #215
Well. Cya.