Skip to content

Commit

Permalink
fix(core/chart): remove unused chart piecelabel plugin
Browse files Browse the repository at this point in the history
plugins can now be added via registerChartPlugins hook
  • Loading branch information
trik committed Jun 25, 2020
1 parent 4a37122 commit 2d4d49d
Show file tree
Hide file tree
Showing 9 changed files with 0 additions and 34 deletions.
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@
"@webcomponents/custom-elements": "^1.3.2",
"@zxing/library": "^0.15.2",
"chart.js": "^2.9.3",
"chart.piecelabel.js": "^0.15.0",
"core-js": "^2.6.11",
"css-element-queries": "^1.2.3",
"date-fns": "^2.9.0",
Expand Down
1 change: 0 additions & 1 deletion packages.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ THIRD_PARTY_GEN_BUNDLES = [
("@ionic/core/loader", "ionic-core-loader-bundle.js"),
("@zxing/library", "zxing-library-bundle.js"),
("chart.js", "chart.js-bundle.js"),
("chart.piecelabel.js", "chart.piecelabel.js-bundle.js"),
("css-element-queries", "css-element-queries-bundle.js"),
("date-fns", "date-fns-bundle.js"),
("debug", "debug-bundle.js"),
Expand Down
1 change: 0 additions & 1 deletion rollup-globals.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ ROLLUP_GLOBALS = {
"@zxing/library": "zxing",
"@ngx-translate/core": "ngxTranslate.core",
"chart.js": "Chart",
"chart.piecelabel.js": "Chart.piecelabel",
"css-element-queries": "cssElementQueries",
"date-fns": "dateFns",
"debug": "debug",
Expand Down
1 change: 0 additions & 1 deletion src/core/chart/chart.ts
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ import {
ChartTooltipModel,
ChartTooltipItem,
} from 'chart.js';
import 'chart.piecelabel.js';

import {deepCopy} from '@ajf/core/utils';
import {ExtendedChartType} from './extended-chart-type';
Expand Down
1 change: 0 additions & 1 deletion src/core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
"@ngx-translate/core": "0.0.0-ANGXT",
"@zxing/library": "^0.15.2",
"chart.js": "^2.9.3",
"chart.piecelabel.js": "^0.15.0",
"css-element-queries": "^1.2.3",
"date-fns": "^2.9.0",
"debug": "^4.1.1",
Expand Down
1 change: 0 additions & 1 deletion src/dev-app/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ filegroup(
":system-config",
"//tools:system-rxjs-operators.js",
"//tools/third-party-libs:chart.js-bundle.js",
"//tools/third-party-libs:chart.piecelabel.js-bundle.js",
"//tools/third-party-libs:css-element-queries-bundle.js",
"//tools/third-party-libs:date-fns-bundle.js",
"//tools/third-party-libs:debug-bundle.js",
Expand Down
1 change: 0 additions & 1 deletion test/karma.conf.js
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ module.exports = config => {
{pattern: 'node_modules/@zxing/library/umd/index.min.js', included: false, watched: false},

{pattern: 'node_modules/chart.js/Chart.umd.js', included: false, watched: false},
{pattern: 'node_modules/chart.piecelabel.js/build/Chart.PieceLabel.min.js', included: false, watched: false},
{pattern: 'node_modules/css-element-queries/css-element-queries.umd.js', included: false, watched: false},
{pattern: 'node_modules/date-fns/date-fns.umd.js', included: false, watched: false},
{pattern: 'node_modules/debug/debug.umd.js', included: false, watched: false},
Expand Down
12 changes: 0 additions & 12 deletions tools/third-party-libs/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -15,18 +15,6 @@ third_party_bundle(
],
)

third_party_bundle(
name = "chart.piecelabel.js",
entry_point = "@npm//:node_modules/chart.piecelabel.js/src/Chart.PieceLabel.js",
globals = {
"chart.js": "chart.js",
},
module_name = "chart.piecelabel.js",
deps = [
"@npm//chart.piecelabel.js",
],
)

third_party_bundle(
name = "css-element-queries",
entry_point = "@npm//:node_modules/css-element-queries/index.js",
Expand Down
15 changes: 0 additions & 15 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2628,14 +2628,6 @@ chardet@^0.7.0:
resolved "https://registry.yarnpkg.com/chardet/-/chardet-0.7.0.tgz#90094849f0937f2eedc2425d0d28a9e5f0cbad9e"
integrity sha512-mT8iDcrh03qDGRRmoA2hmBJnxpllMR+0/0qlzjqZES6NdiWDcZkCNAk4rPFZ9Q85r27unkiNNg8ZOiwZXBHwcA==

chart.js@^2.1.5:
version "2.8.0"
resolved "https://registry.yarnpkg.com/chart.js/-/chart.js-2.8.0.tgz#b703b10d0f4ec5079eaefdcd6ca32dc8f826e0e9"
integrity sha512-Di3wUL4BFvqI5FB5K26aQ+hvWh8wnP9A3DWGvXHVkO13D3DSnaSsdZx29cXlEsYKVkn1E2az+ZYFS4t0zi8x0w==
dependencies:
chartjs-color "^2.1.0"
moment "^2.10.2"

chart.js@^2.9.3:
version "2.9.3"
resolved "https://registry.yarnpkg.com/chart.js/-/chart.js-2.9.3.tgz#ae3884114dafd381bc600f5b35a189138aac1ef7"
Expand All @@ -2644,13 +2636,6 @@ chart.js@^2.9.3:
chartjs-color "^2.1.0"
moment "^2.10.2"

chart.piecelabel.js@^0.15.0:
version "0.15.0"
resolved "https://registry.yarnpkg.com/chart.piecelabel.js/-/chart.piecelabel.js-0.15.0.tgz#d28ff4fa3857d1e96d468c0b7cb397ff0c7bd08f"
integrity sha512-FDFsqw9vsEIS3Mv5o+GKuu+d4GboCX4dR7gnPsMtZuBrPAZSPBu3g074GjCB/lSvORZAE9PfjnMN15KMOyaypA==
dependencies:
chart.js "^2.1.5"

chartjs-color-string@^0.6.0:
version "0.6.0"
resolved "https://registry.yarnpkg.com/chartjs-color-string/-/chartjs-color-string-0.6.0.tgz#1df096621c0e70720a64f4135ea171d051402f71"
Expand Down

0 comments on commit 2d4d49d

Please sign in to comment.