fix(core/models): ALL_VALUES_OF is not extracting values from main forms

projects/core/models/src/utils/expression-utils.spec.ts

@@ -0,0 +1,19 @@
+import {ALL_VALUES_OF, MainForm} from './expression-utils';
+
+describe('ALL_VALUES_OF', () => {
+  it('should get all values by key in dataset', () => {
+    const result = ALL_VALUES_OF(forms, 'dog_name');
+    const dogs = 4;
+    expect(result.length).toBe(dogs);
+    for (let i = 1; i <= dogs; i++) {
+      expect(result).toContain(`dog${i}`);
+    }
+  });
+});
+
+const forms: MainForm[] = [
+  {dog_name: 'dog1', reps: {'rep_1': [{dog_name: 'dog4'}]}},
+  {},
+  {dog_name: 'dog2'},
+  {dog_name: 'dog3'},
+];

projects/core/models/src/utils/expression-utils.ts

@@ -152,6 +152,8 @@ export class AjfExpressionUtils {
   };
 }
 
+const nonNullInstances = (reps: Instances | undefined): reps is Instances => reps != null;
+
 /**
  * UTILITY FUNCION
  * This function provide a deep copy builder of array of main forms.
@@ -669,16 +671,22 @@ export function getCoordinate(source: any, zoom?: number): [number, number, numb
  * Calculates all the possible results that a field has taken
  */
 export function ALL_VALUES_OF(mainforms: MainForm[], fieldName: string): string[] {
-  const allreps = (mainforms || [])
-    .slice(0)
-    .map(m => m.reps)
-    .filter(c => c != null)
-    .map((i: unknown) =>
-      Object.keys(i as Instances)
-        .map(k => (i as Instances)[k])
-        .flat(),
-    )
-    .flat();
+  const forms = [...(mainforms || [])];
+  const allreps = [
+    ...forms.map(form => {
+      const {reps, ...v} = form;
+      return v;
+    }),
+    ...forms
+      .map(m => m.reps)
+      .filter(nonNullInstances)
+      .map(i =>
+        Object.keys(i)
+          .map(k => i[k])
+          .flat(),
+      )
+      .flat(),
+  ];
 
   return [...new Set(allreps.filter(f => f[fieldName] != null).map(f => `${f[fieldName]}`))];
 }