fix(core/forms): classes using Angular features need to be decorated

AjfTableFieldComponent and AjfVideoUrlFieldComponent were using `Inject` decorator in constructor but were not decorated with `Directive`
gnucoop · Oct 13, 2021 · b934078 · b934078
1 parent e2cf7a9
commit b934078
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/src/core/forms/table-field.ts b/src/core/forms/table-field.ts
@@ -20,7 +20,7 @@
  *
  */
 
-import {ChangeDetectorRef, Inject} from '@angular/core';
+import {ChangeDetectorRef, Directive, Inject} from '@angular/core';
 
 import {AjfBaseFieldComponent} from './base-field';
 import {AjfFormRendererService} from './form-renderer';
@@ -37,6 +37,7 @@ import {AJF_WARNING_ALERT_SERVICE, AjfWarningAlertService} from './warning-alert
  * @abstract
  * @class AjfTableFieldComponent
  */
+@Directive()
 export abstract class AjfTableFieldComponent extends AjfBaseFieldComponent<AjfTableFieldInstance> {
   constructor(
       cdr: ChangeDetectorRef, service: AjfFormRendererService,

diff --git a/src/core/forms/video-url-field.ts b/src/core/forms/video-url-field.ts
@@ -21,7 +21,7 @@
  */
 
 import {HttpClient} from '@angular/common/http';
-import {ChangeDetectorRef, Inject} from '@angular/core';
+import {ChangeDetectorRef, Directive, Inject} from '@angular/core';
 import {FormControl} from '@angular/forms';
 import {DomSanitizer, SafeResourceUrl} from '@angular/platform-browser';
 import {Observable, of as obsOf} from 'rxjs';
@@ -44,6 +44,7 @@ interface VideoInfo {
  * @export
  * @class AjfVideoUrlFieldComponent
  */
+@Directive()
 export class AjfVideoUrlFieldComponent extends AjfBaseFieldComponent {
   readonly validUrl: Observable<boolean>;
   readonly videoThumbnail: Observable<SafeResourceUrl>;

diff --git a/tools/public_api_guard/core/forms.md b/tools/public_api_guard/core/forms.md
@@ -1130,6 +1130,10 @@ export abstract class AjfTableFieldComponent extends AjfBaseFieldComponent<AjfTa
     constructor(cdr: ChangeDetectorRef, service: AjfFormRendererService, was: AjfWarningAlertService);
     goToCell(row: number, column: number): void;
     goToNextCell(ev: Event, row: number, column: number): void;
+    // (undocumented)
+    static ɵdir: i0.ɵɵDirectiveDeclaration<AjfTableFieldComponent, never, never, {}, {}, never>;
+    // (undocumented)
+    static ɵfac: i0.ɵɵFactoryDeclaration<AjfTableFieldComponent, never>;
 }
 
 // @public
@@ -1244,6 +1248,10 @@ export class AjfVideoUrlFieldComponent extends AjfBaseFieldComponent {
     readonly validUrl: Observable<boolean>;
     // (undocumented)
     readonly videoThumbnail: Observable<SafeResourceUrl>;
+    // (undocumented)
+    static ɵdir: i0.ɵɵDirectiveDeclaration<AjfVideoUrlFieldComponent, never, never, {}, {}, never>;
+    // (undocumented)
+    static ɵfac: i0.ɵɵFactoryDeclaration<AjfVideoUrlFieldComponent, never>;
 }
 
 // @public (undocumented)